Ticket #11655 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

CropWorkspace's ragged binning behavior is not obvious

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: critical Milestone: Release 3.5
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description (last modified by Harry Jeffery) (diff)

When CropWorkspaces encounters ragged bins, it doesn't remove bins, but sets ones outside the crop range to 0. Owen and I were briefly confused by this, so perhaps it should be a little more obvious.

Change History

comment:1 Changed 5 years ago by Harry Jeffery

  • Status changed from new to assigned
  • Description modified (diff)
  • Summary changed from CropWorkspace fails silently on ragged workspaces to CropWorkspace's ragged binning behavior is not obvious

comment:2 Changed 5 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

Refs #11655 Log information about ragged cropping behaviour

Changeset: db891d7e2a138e791193efa635d025b54596a327

comment:3 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #683.

comment:4 Changed 5 years ago by Karl Palmen

It would be helpful (for testing) to know where one could find a ragged workspace.

comment:5 Changed 5 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:6 Changed 5 years ago by Harry Jeffery

@KarlPalmen Open the ISIS Reflectometry (Polref) interface, select INTER as the instrument and add a row with Run(s) = 13460, and Angle = 0.7. Process that row and in the ADS you'll find IvsQ_13460, which is ragged, i.e. the bin widths vary between spectra.

comment:7 Changed 5 years ago by Karl Palmen

Thank you @eXeC64 for the information.

comment:8 Changed 5 years ago by Karl Palmen

The code review shows the only change is to get CropWorkspace to display a message if the workspace is ragged. I have not been able to get it to display this message.

comment:9 Changed 5 years ago by Harry Jeffery

That's strange, a couple of things to double check:

  • The X values vary between spectra.
  • Results log is set to show information level messages.

comment:10 Changed 5 years ago by Karl Palmen

I found that I had my results log set at notice level. Changing it to information level caused the message to appear after other information.

comment:11 Changed 5 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge pull request #683 from mantidproject/11655_cropworkspace_is_non_obvious

Make ragged cropping behaviour more obvious

Full changeset: ​5caf97ee32b34ca5320404dfdbfa4a5668299c62

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12493

Note: See TracTickets for help on using tickets.