Ticket #11659 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Replace custom search method in Kernel::Interpolation

Reported by: Michael Wedel Owned by: Michael Wedel
Priority: major Milestone: Release 3.5
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

In ticket #9682 a binary search was implemented in Kernel::Interpolation because the x-values are always in a sorted state.

I ran some quick tests and I would like to replace the custom search method with std::lower_bound, as that speeds up the lookup a bit and makes the code much simpler.

Change History

comment:1 Changed 5 years ago by Michael Wedel

  • Status changed from new to inprogress

Refs #11659. Replace recursive binary search with std::lower_bound

Changeset: 565fda08432710b559accc4a047a4a4ae5ed6a12

comment:2 Changed 5 years ago by Michael Wedel

Refs #11659. Remove parameters from function definition

The parameters were required for the recursion and are no longer necessary.

Changeset: 702788fefc04b8fc1baea8a11c2fe0c1dbcc7f3c

comment:3 Changed 5 years ago by Michael Wedel

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #685.

comment:4 Changed 5 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:5 Changed 5 years ago by Michael Wedel

Refs #11659. Replace recursive binary search with std::lower_bound

Changeset: 565fda08432710b559accc4a047a4a4ae5ed6a12

comment:6 Changed 5 years ago by Michael Wedel

Refs #11659. Remove parameters from function definition

The parameters were required for the recursion and are no longer necessary.

Changeset: 702788fefc04b8fc1baea8a11c2fe0c1dbcc7f3c

comment:7 Changed 5 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge pull request #685 from mantidproject/11659_replace_custom_binary_search_in_interpolation

Replace custom binary search in Kernel::Interpolation

Full changeset: 39361938cc3fe0fe58b3abdeff55923f4eecbd4e

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12497

Note: See TracTickets for help on using tickets.