Ticket #11688 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Q Limits issue found in Max's Gui

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: critical Milestone: Release 3.5
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

Max has reported this issue with his gui.

  • Process a row with the Stitch option enabled. This is definitely running Stitch1D if you look at the history.
  • Plot the results and the limits in the plot look right
  • Now change the Q limits and recalculate/replot. Although Stich1D was given the right limits, the resulting graph has the wrong limits.
  • Fix this and check the situation doesn't apply to the new batch processing script.

Change History

comment:1 Changed 5 years ago by Harry Jeffery

  • Status changed from new to inprogress

comment:2 Changed 5 years ago by Harry Jeffery

Refs #11688 Respect qlimits when stitching

Changeset: 572c6f4fccde54fcd44b486780d2be02d2d74f16

comment:3 Changed 5 years ago by Harry Jeffery

Refs #11688 Fix rounding error

Changeset: 8dc4fcd0ea91d1b41229d1309285b00653e9e4db

comment:4 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #708.

comment:5 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:6 Changed 5 years ago by Federico Montesino Pouzols

Works well in all the variations that I tried, using values similar to the ones from https://github.com/mantidproject/mantid/pull/679.

comment:7 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #708 from mantidproject/11688_qlimits_issue

Fix qlimits issue in old reflectometry GUI

Full changeset: 7e61d8708c95187ff8fcb050fb93f25671c01ce8

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 12526

Note: See TracTickets for help on using tickets.