Ticket #11704 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

LineViewer bug with special values

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: critical Milestone: Release 3.4
Component: Framework Keywords: vates
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

plotMD is fine, but looks like special values are messing with the in-built plot. Both plots are looking at the same workspace, so the plots should be the same.

  • See image in zip attached.
  • Data is in the zip to reproduce this

Change History

comment:1 Changed 5 years ago by Owen Arnold

I'll send zip file separately

comment:2 Changed 5 years ago by Harry Jeffery

  • Status changed from new to inprogress

comment:3 Changed 5 years ago by Harry Jeffery

Refs #11704 Handle NaNs correctly

Changeset: 512fb37f618f5968b64bcd988e961e28cf8f93b1

comment:4 Changed 5 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #735.

comment:5 Changed 5 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 5 years ago by Harry Jeffery

Refs #11704 Add required includes

Changeset: 62bfebd3a4d86485c30a3e5659c0d7f906ba6a0a

comment:7 Changed 5 years ago by Harry Jeffery

  • Status changed from verifying to verify
  • Tester Owen Arnold deleted

comment:8 Changed 5 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:9 Changed 5 years ago by Roman Tolchenov

Can I have the test data please?

comment:10 Changed 5 years ago by Harry Jeffery

Refs #11704 Remove unused function

Changeset: a76c494a296bbadf6b316fd13593193fcede67f2

comment:11 Changed 5 years ago by Harry Jeffery

Refs #11704 Improve handling of min/max

Changeset: 612027b690d853d99211cc385ba8216b330bd693

comment:12 Changed 5 years ago by Harry Jeffery

Refs #11704 Handle min/max betrer in QwtWorkspaceBinData

Changeset: da22c5c0f3619d6e8d47756c1bbe397dabc47a73

comment:13 Changed 5 years ago by Harry Jeffery

Refs #11704 Correctly handle min/max in QwtWorkspaceSpectrumData

Changeset: 9df4c2048a040c3396bd430ffa12871f77ac8a13

comment:14 Changed 5 years ago by Harry Jeffery

Refs #11704 Fix minPositive getting stuck at 0

Changeset: b245e9a21d0a228cea092351d810e9aa4f2089e4

comment:15 Changed 5 years ago by Harry Jeffery

Refs #11704 Update broken tests

Previously, the minPositive value would get stuck at 0. It now goes to the actual minimum positive value, so the tests needs to reflect this when data is clamped to minPositive.

Changeset: a291fa0d001a2e3193aa44140270d59b97973886

comment:16 Changed 5 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge pull request #735 from mantidproject/11704_handle_nan_correctly

Plot NaNs correctly in the sliceviewer

Full changeset: ​ac0ed00bb315e46a4343060e40ff218a2c2c72cc

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12542

Note: See TracTickets for help on using tickets.