Ticket #11708 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

VSI workspace + settings on each view

Reported by: Owen Arnold Owned by: Federico M Pouzols
Priority: critical Milestone: Release 3.4
Component: Framework Keywords: vates
Cc: anton.piccardo-selg@…, nick.draper@… Blocked By:
Blocking: Tester: NickDraper

Description

People flick between views, the views either need to be synced fully, or they need to remember their own locations and settings. This was particularly noticeable on the three slice view where location , zoom and slice increments were lost on returning to the view. This should apply only when the workspace is the same in the same session of the VSI.

Ask Anton and Owen for help with this.

Change History

comment:1 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from new to inprogress

use m_ prefix for data memters, re #11708

Changeset: 5fd01c965ad126d7092f64b2216565ba4ad1f5a4

comment:2 Changed 5 years ago by Federico Montesino Pouzols

use m_ prefix for data members and remove unused member, re #11708

Changeset: 84065f2fc8877c5fc4b362bf47d19bc0c8f1076b

comment:3 Changed 5 years ago by Federico Montesino Pouzols

save/restore visual state of views when switching between, re #11708

Changeset: 8e8fab7d6c935a784b98ae7248ad1316260fdd91

comment:4 Changed 5 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin' into 11708_vsi_keep_settings_on_each_view_for_workspaces_within_a_session

Conflicts:

Code/Mantid/Vates/VatesSimpleGui/ViewWidgets/inc/MantidVatesSimpleGuiViewWidgets/MdViewerWidget.h Code/Mantid/Vates/VatesSimpleGui/ViewWidgets/src/MdViewerWidget.cpp Code/Mantid/Vates/VatesSimpleGui/ViewWidgets/src/SplatterPlotView.cpp Code/Mantid/Vates/VatesSimpleGui/ViewWidgets/src/StandardView.cpp

Sort out conflict with another recently merged branch, re #11708

Changeset: 5bcb57464d253ba26a0b3c40338c63b512dda00a

comment:5 Changed 5 years ago by Federico Montesino Pouzols

use vtk smart pointer for the view states, re #11708

Changeset: df0e169ea811aca4e8c43814a18a52d37d23612d

comment:6 Changed 5 years ago by Federico Montesino Pouzols

add button: reset views state, re #11708

Changeset: ae0f9b6bc9e2d5618d2451bc33ad103c9537c1a7

comment:7 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #740.

comment:8 Changed 5 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/master' into 11708_vsi_keep_settings_on_each_view_for_workspaces_within_a_session

Conflicts:

Code/Mantid/Vates/VatesSimpleGui/ViewWidgets/inc/MantidVatesSimpleGuiViewWidgets/StandardView.h Code/Mantid/Vates/VatesSimpleGui/ViewWidgets/src/StandardView.cpp

Sort out merge conflict that arised after another VSI related branch was merged into master, re #11708

Changeset: f2272312eb316a4d24694f21f6ab49d600b8afc0

comment:9 Changed 5 years ago by NickDraper

  • Status changed from verify to closed
  • Tester set to NickDraper

Merge pull request #740 from mantidproject/11708_vsi_keep_settings_on_each_view_for_workspaces_within_a_session

VSI: keep the state of views when switching between them

Full changeset: ​42624e5f0382f50d9b816bc1be4d07d4bc9f2991

comment:10 Changed 5 years ago by Federico Montesino Pouzols

I've added [#11760 ](​http://trac.mantidproject.org/mantid/ticket/11760) for the remaining three slice issue.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12545

Note: See TracTickets for help on using tickets.