Ticket #11728 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Create Mantid Direct inelastic configuration builder

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.5
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description (last modified by Alex Buts) (diff)

There is already one used by ISIS IT support which I've written.

It would benefit from bringing it to Mantid to be modifiable according to changes in Mantid and writing couple of unit tests for its operations.

Change History

comment:1 Changed 5 years ago by Alex Buts

  • Status changed from new to inprogress
  • Component changed from Framework to Direct Inelastic

comment:2 Changed 5 years ago by Alex Buts

  • Description modified (diff)

comment:3 Changed 5 years ago by Alex Buts

Re #11728 Extracted builder and started unit tests for configuration

Changeset: 4ff442b7ffa2cc8ea9c75d503659bb2895759037

comment:4 Changed 5 years ago by Alex Buts

Re #11728 Test configurer creation

Changeset: 30e020dc825f5b5fa57cf65eadd9f94de56d424b

comment:5 Changed 5 years ago by Alex Buts

Re #11728 Configuration with some bugs fixed

and unit test for it

Changeset: f2b49682bbe47686e4314d4dde4adc85203ab110

comment:6 Changed 5 years ago by Alex Buts

Re #11728 Data search works presumably fine

Changeset: f32cd96f82379051326955a513e0348488292e5d

comment:7 Changed 5 years ago by Alex Buts

Re #11728 Copied special sample file to users directory

Changeset: 409d20c012c7c903a41a69c6614974e9f389593d

comment:8 Changed 5 years ago by Alex Buts

fixed as PR ​https://github.com/mantidproject/mantid/pull/742

This ticket is in some way external to Mantid and intended to create a Mantid configuration suitable for Direct Inelastic reduction & other common operations for ISIS instrument's users, who login into ISIS reduction machines.

It was working during the cycle on the machines but some data folders were incorrect. I put it in Mantid and wrote couple of unit tests to verify it. It heavily relies on the agreed configuration of the ISIS computers.

Test by code review bearing in mind it was working. Only number of unit tests have been added.

comment:9 Changed 5 years ago by Alex Buts

Re #11728 attempt to work when no save directory is defined

to fix unit test on Unix were it fails as no default.savedirectory is defined.

Changeset: 079a5a6fca2a0a22743890fb84296795b520b066

comment:10 Changed 5 years ago by Alex Buts

Re #11728 fixing Unix discrepancies.

Changeset: 1f4b36d83ce10b2e41d4a3ebb26483095b3cfb11

comment:11 Changed 5 years ago by Alex Buts

Re #11728 Trying to identify problem with config_path.

Changeset: 5193f8aebf30124d651477850e5216c110f18dd4

comment:12 Changed 5 years ago by Alex Buts

Re #11728 Bug invisible on windows

Changeset: 59e487fa68b361e1fbb86ff0c697b983d74f8b3d

comment:13 Changed 5 years ago by Alex Buts

Re #11728 Changes to exclude duplicated data search folders

Changeset: e15b9089af32e3831bc7474b9ae0bbfa458845de

comment:14 Changed 5 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Resolution set to fixed

I know that remaining test failures are caused by Mantid have not rebuilding C++ code. This ticket's tests are all passing.

See above on how to test it.

Last edited 5 years ago by Alex Buts (previous) (diff)

comment:15 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:16 Changed 5 years ago by Federico Montesino Pouzols

All looks fine and tests pass. Real testing of all the functionality would require accounts and knowledge of specific details, but the test included here is exhaustive enough and definitely better than not having it integrated.

The only issue is that this introduced 15 pylint warnings in Direct/ISISDirecInelasticConfig.py None of them are real/serious issues, except maybe line "190: wrong indentation". All others are "too long line", "trailing whitespaces", and a special variable name fp that pylint dislikes. So please try to fix those and/or disable the pylint warnings when you update the code.

comment:17 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #742 from mantidproject/11728_ISISConfigBuilder

Mantid configuration builder for ISIS computing.

Full changeset: ​8b00f93637f119699bdb030d41a11f2b6d2017ad

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12566

Note: See TracTickets for help on using tickets.