Ticket #11761 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Reenable failing LET_Multirep system test

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.5
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description

disabled due to problems with Windows not rebuilding some precompiled headers.

Change History

comment:1 Changed 5 years ago by Alex Buts

  • Status changed from new to inprogress

Re #11761 Disabling LETReductionEvent2015Multirep until

Windows build fixed.

Changeset: 49f9e25aee019969e8d8e3f53e663ee301c181a5

comment:2 Changed 5 years ago by Alex Buts

Re #11761 Reenabling the test

Changeset: 151517f065dc80be2fb691cc589a34735537b474

comment:3 Changed 5 years ago by abuts

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #765.

comment:4 Changed 5 years ago by Alex Buts

should be fixed as PR ​https://github.com/mantidproject/mantid/pull/765

No changes to the code -- just the test failing earlier due to jenkins not rebuilding with correct precompiled headers is enabled.

comment:5 Changed 5 years ago by Alex Buts

Re #11761 Also reenabled doctest for the feature, the failing test

depends on

Changeset: ee3229c9c0d017b6f0ded9bc96e2d1432173b9f8

comment:6 Changed 5 years ago by Alex Buts

No changes to the code -- system test and doc test reenabled.

comment:7 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:8 Changed 5 years ago by Federico Montesino Pouzols

All system and doc tests pass. I also run the docs-test and all the ISISDirectInelastic tests including LET ones locally without any issues. Let's see if the nightly builds/tests go well as they should.

comment:9 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #765 from mantidproject/11761_failingLETMultirep

reenabling LET system test

Full changeset: ​7fce5d90bae5275f95d38b7feeadbf4a899a5eca

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12599

Note: See TracTickets for help on using tickets.