Ticket #11765 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Segfault when closing ISIS SANS

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Anton Piccardo-Selg

Description

Have no data search directories specified and close the ISIS SANS interface.

Change History

comment:1 Changed 5 years ago by Dan Nixon

  • Status changed from new to inprogress

Fix segfault when closing ISIS SANS interface

Refs #11765

Changeset: a66708b4a1f649c29faaa238579ac9e8d7beb971

comment:2 Changed 5 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #753.

comment:3 Changed 5 years ago by Owen Arnold

This looks to be low risk and stops a crash that first time users of mantid and sans could definitely walk into. It wouldn't be easy to users to understand why this crash has occured so in my opinion, better to use this simple fix to stop that from happening in the first place.

comment:4 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from verify to verifying
  • Tester set to Anton Piccardo-Selg

comment:5 Changed 5 years ago by Owen Arnold

I don't know the SANS interface well enough to establish if there would be any other downstream effects from these changes, so I've set Anton as the tester.

comment:6 Changed 5 years ago by Anton Piccardo-Selg

For testing performed

  • Loaded user file
  • Loaded data set for SANS2D
  • Performed 1D data reduction
  • Performed 2D data reduction

All was able to perform without difficulties. At this point, i cannot see that the fix is a problem.

comment:7 Changed 5 years ago by Anton Piccardo-Selg

  • Status changed from verifying to closed

Merge pull request #753 from mantidproject/11765_fix_isis_sans_segfault

Fix segfault when closing ISIS SANS interface

Full changeset: ​a7db0aa8a5e58eda9b6d6a0ac3e1f2b4ce17ecf7

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​12603

Note: See TracTickets for help on using tickets.