Context Navigation

Ticket #11825 (closed: fixed)

Opened 5 years ago

Last modified 5 years ago

Coverity issues: Muon and NeXus load issues

Reported by:	Federico M Pouzols	Owned by:	Raquel Alvarez Banos
Priority:	major	Milestone:	Release 3.5
Component:	Framework	Keywords:	Maintenance
Cc:		Blocked By:
Blocking:	#10619, #11791	Tester:	Federico Montesino Pouzols

Description

A couple of Muon ones (missing initialization of non-static class data members):

1256944
1075321

And then these ones related to data/Nexus loading, mostly related to missing initializations and ignored return values: -1075414 -1215227 -1215240 -1075531 -1075394 -1075392 -1075391 -1076052 -1075322 -1075952

I've already assigned them to you on the coverity website. Try to get rid of as many as possible, and feel free to change/add/remove issues depending on what you see when you get your hands on these issues.

Change History

comment:1 Changed 5 years ago by Federico M Pouzols

Blocked By 11826 added

comment:2 Changed 5 years ago by Federico M Pouzols

Blocked By 11826 removed

comment:3 Changed 5 years ago by Raquel Alvarez Banos

Status changed from new to inprogress

Re #11825 Addit missing member variables to initialization list

Changeset: 95c6322f2d453d76376d426d7c57df83e59c2db3

comment:4 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Add missing member variables to initialization list

Changeset: a8ee4e9f6b1b5bad9181aeee22e243498196a592

comment:5 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Add missing members to initialization list

Changeset: e32010313419a7543040771d56a1467cf56e0edb

comment:6 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Applying naming conventions

Changeset: d4f3700778f1efeb92ddd6a2d9540ab079a62035

comment:7 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Avoid dividing by zero

Changeset: 19d1658f56fd3d512426d9c7c82a8c2b700fa823

comment:8 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Fixing initialization list, adding missing members

Changeset: aba85e92859684bb9161994ba0424b1119c70379

comment:9 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Fixing initialization list

Changeset: 01d7a986105efc07c9d6622921c73ecf3152ed9c

comment:10 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Initialization list again

Changeset: edb1826610663a61716429a314075624a3911482

comment:11 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Another incomplete initialization list

Changeset: 49ebd07a68cbc0f455882abbffaea2e8a29c3a17

comment:12 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Removing dead code

Changeset: fce3b70f1f8fb3957bec5d2a42d874c5558d053c

comment:13 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Check the number of bytes read

Changeset: f9b76d9902542b4b342b4e7c4ffb43da56c37df2

comment:14 Changed 5 years ago by Raquel Alvarez

Status changed from inprogress to verify
Resolution set to fixed

This is being verified as pull request #797.

comment:15 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Fix compiler warnings

Changeset: 8e43c2b59a101faea4677fee24a60dcdc6bec0d2

comment:16 Changed 5 years ago by Federico Montesino Pouzols

Status changed from verify to verifying
Tester set to Federico Montesino Pouzols

comment:17 Changed 5 years ago by Raquel Alvarez Banos

Re #11825 Progress should be a local variable

Changeset: b0472cb8491ae6d60b373dce5e56143f87ddf17b

comment:18 Changed 5 years ago by Federico Montesino Pouzols

We got failures in the DownloadFile test which are unrelated (not bothering to recompile). Code changes look good to me. This should fix a good bunch of coverity issues.