Ticket #1624 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Slicing Rebinning Filter

Reported by: Nick Draper Owned by: Owen Arnold
Priority: critical Milestone: Iteration 29
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

Slicing rebinning filter. Allows clipping/cutting operations. Allows resolution (in terms on n of bins to be specified). View and Presenter required. Drives Mantid back-end algorithms.

Change History

comment:1 Changed 10 years ago by Owen Arnold

(In [7268]) refs #1624 mantid-like icon/logo update

comment:2 Changed 10 years ago by Owen Arnold

(In [7315]) refs #1624 Work to provide richer GUI according to ADD mock-ups.

comment:3 Changed 10 years ago by Owen Arnold

(In [7363]) refs #1624 uninitalised widgets causing runtime error.

comment:4 Changed 10 years ago by Owen Arnold

(In [7831]) refs #1624 Get rid of tests in visualisation plugin directory.

comment:5 Changed 10 years ago by Owen Arnold

(In [7834]) refs #1624 Remove old helper class.

comment:6 Changed 10 years ago by Owen Arnold

(In [7835]) refs #1624 Update cmake script

comment:7 Changed 10 years ago by Owen Arnold

(In [7837]) refs #1624 Add presenter package.

comment:8 Changed 10 years ago by Owen Arnold

(In [7893]) refs #1624. Simpler construction for ImplicitFunctions.

comment:9 Changed 10 years ago by Owen Arnold

(In [7924]) refs #1624 Update to use new ImplicitFunctionFactory where no parser schema needs to be specified.

comment:10 Changed 10 years ago by Owen Arnold

(In [8025]) refs #1624. BoxImplicit function and the ability to drive rebinning from xml.

comment:11 Changed 10 years ago by Owen Arnold

(In [8027]) refs #1624. Remove scope resolution operator error.

comment:12 Changed 10 years ago by Owen Arnold

(In [8049]) refs #1624. Fix Seg Error resulting from modifications to xml schema

comment:13 Changed 10 years ago by Owen Arnold

(In [8052]) refs #1624. Link against MDDataObjects

comment:14 Changed 10 years ago by Owen Arnold

(In [8089]) refs #1624 Solve vtk library problem which gave buggy filter.

comment:15 Changed 10 years ago by Owen Arnold

(In [8098]) refs #1624 Clean-up presenter operation prior to introduction of box extents.

comment:16 Changed 10 years ago by Owen Arnold

(In [8102]) refs #1624 Switch to use of box extents. Intermediate step prior to actual calls to DynamicRebinning and Qt Widgets to drive attribute creation.

comment:17 Changed 10 years ago by Owen Arnold

(In [8109]) refs #1624. Implement methods to serialize domain objects for visualisation communications.

comment:18 Changed 10 years ago by Owen Arnold

(In [8126]) refs #1624. Small modification to IMDWorkspace to allow access to Geometry xml.

comment:19 Changed 10 years ago by Owen Arnold

(In [8130]) refs #1624 Convert domain objects to xml.

comment:20 Changed 10 years ago by Owen Arnold

(In [8132]) refs #1624 Convert domain objects to xml. Add additional constructon routes.

comment:21 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:22 Changed 10 years ago by Owen Arnold

(In [8169]) refs #1624 Now Handles full xml schema not just function aspects. DynamicRebinning algorithm not yet hooked-up.

comment:23 Changed 10 years ago by Owen Arnold

(In [8172]) refs #1624 Modifications for GCC compatibility. Additional test for DynamicRebinningXML.

comment:24 Changed 10 years ago by Owen Arnold

(In [8173]) refs #1624 Modifications for GCC compatibility. Additional test for DynamicRebinningXML.

comment:25 Changed 10 years ago by Owen Arnold

(In [8174]) refs #1624 Modifications for GCC compatibility. Additional test for DynamicRebinningXML.

comment:26 Changed 10 years ago by Owen Arnold

(In [8274]) refs #1624 Rebinning slicing operations. First pass db added.

comment:27 Changed 10 years ago by Owen Arnold

(In [8281]) refs #1624 Provide 4th dimension as time in VisIT db.

comment:28 Changed 10 years ago by Owen Arnold

(In [8453]) refs #1624. Update metadata schema.

comment:29 Changed 10 years ago by Owen Arnold

(In [8458]) refs #1624 CMake script for building MDDataObjects. Rough at this stage.

comment:30 Changed 10 years ago by Owen Arnold

(In [8477]) refs #1624. Progress towards hdf5 handling. Find module as next step.

comment:31 Changed 10 years ago by Owen Arnold

(In [8478]) refs #1624 No need to link against gtest

comment:32 Changed 10 years ago by Owen Arnold

(In [8482]) refs #1624 CMake for MDAlgorithms working. All tests pass. However. OpenMP code, not happy cross platform and has therefore been disabled. OpenMP code will need to be fixed.

comment:33 Changed 10 years ago by Owen Arnold

(In [8483]) refs #1624 Fix to provide headers for MDDataObjects.

comment:34 Changed 10 years ago by Owen Arnold

(In [8491]) refs #1624 Preliminary CMake scripts for VisitPresenters.

comment:35 Changed 10 years ago by Owen Arnold

(In [8501]) refs #1624 Visit presenters build under cmake. Tests run from sh script. All pass. Test script not great, but soon to be ditched.

comment:36 Changed 10 years ago by Michael Reuter

(In [8532]) Commenting out currently unused class. This refs #1624.

comment:37 Changed 10 years ago by Owen Arnold

(In [8542]) refs #1624 Allow specification of MANTIDPATH for external applications.

comment:38 Changed 10 years ago by Owen Arnold

(In [8543]) refs #1624 Fixes to support use of seperate md workspace loading algorithm

comment:39 Changed 10 years ago by Owen Arnold

(In [8602]) refs #1624 Project 4D dataset from visit database. Working RebinningCutting, but looks like errors in rebinning code causing odd image.

comment:40 Changed 10 years ago by Michael Reuter

(In [8607]) Added missing static member. This refs #1624.

comment:41 Changed 10 years ago by Owen Arnold

(In [8656]) refs #1624 Crude rebinning working in 4D.

comment:42 Changed 10 years ago by Owen Arnold

(In [8714]) refs #1624. Dynamic rebinning with metatdata picked up from pipeline.

comment:43 Changed 10 years ago by Owen Arnold

(In [8765]) refs #1624 Widgets For Displaying Dimensions. Sync when dimension selection is changed.

comment:44 Changed 10 years ago by Owen Arnold

(In [8787]) refs #1624 Widgets For Displaying Dimensions. Can now be populated upon first execution of filter. Minor fixes to display previous extents and to enable volume rendering.

comment:45 Changed 10 years ago by Owen Arnold

(In [8807]) refs #1624 Widgets For Displaying Dimensions. Can now be populated upon first execution of filter. Minor fixes to display previous extents and to enable volume rendering.

comment:46 Changed 10 years ago by Owen Arnold

(In [8810]) refs #1624 Legacy project files removed

comment:47 Changed 10 years ago by Owen Arnold

(In [8896]) refs #1624 Working compound slicing. Other minor fixes for gui controls.

comment:48 Changed 10 years ago by Owen Arnold

(In [8900]) refs #1624 Missing BoxInterpreter

comment:49 Changed 10 years ago by Owen Arnold

(In [8923]) refs #1624 Factory method for grid types. Apply sparse unstructured variation. Next step to fully extract all grid types to factory implementations and dependency inject.

comment:50 Changed 10 years ago by Owen Arnold

(In [8936]) refs #1624. Demo file added to test directory.

comment:51 Changed 10 years ago by Owen Arnold

(In [8945]) refs #1624 Factory methods for grid types now injected at top level. Compile-time policies used to configure geometric and Image information for testability.

comment:52 Changed 10 years ago by Owen Arnold

(In [9042]) refs #1624 Specify Rotation Matrix.

comment:53 Changed 10 years ago by Owen Arnold

(In [9043]) refs #1624 Minor fix to test.

comment:54 Changed 10 years ago by Owen Arnold

(In [9137]) refs #1624 Extend planes to provide basis for rotations and to enable thickness as part of slicing.

comment:55 Changed 10 years ago by Owen Arnold

(In [9141]) refs #1624. Dual virtual plane approach to plane with width for evaluation function. Also address compiler warnings.

comment:56 Changed 10 years ago by Owen Arnold

(In [9142]) refs #1624 Plane may now be interpreted as a rotation against principle axes.

comment:57 Changed 10 years ago by Owen Arnold

(In [9143]) refs #1624 Missing file

comment:58 Changed 10 years ago by Owen Arnold

(In [9151]) refs #1624 Bidirectional synchronization between interactors and attributes. Verify Rebinning rotations in visualisation.

comment:59 Changed 10 years ago by Michael Reuter

(In [9245]) Adding definitions to make library work. Unneeded functions? This refs #1624.

comment:60 Changed 10 years ago by Michael Reuter

(In [9246]) Let data finder handle things since file is in repository. This refs #1624.

comment:61 Changed 10 years ago by Owen Arnold

(In [9262]) refs #1624 Caching

comment:62 Changed 10 years ago by Owen Arnold

(In [9267]) refs #1624 Reorganise

comment:63 Changed 10 years ago by Owen Arnold

(In [9269]) refs #1624 Reorganise

comment:64 Changed 10 years ago by Owen Arnold

(In [9271]) refs #1624 Reorganise

comment:65 Changed 10 years ago by Owen Arnold

(In [9272]) refs #1624 no longer needed

comment:66 Changed 10 years ago by Owen Arnold

(In [9275]) refs #1624 remove inc

comment:67 Changed 10 years ago by Owen Arnold

(In [9276]) refs #1624 move includes

comment:68 Changed 10 years ago by Owen Arnold

(In [9278]) refs #1624 reorganise

comment:69 Changed 10 years ago by Owen Arnold

(In [9279]) refs #1624 reorgainse remove src

comment:70 Changed 10 years ago by Owen Arnold

(In [9280]) refs #1624 New CMakeLists.txt

comment:71 Changed 10 years ago by Owen Arnold

(In [9281]) refs #1624 modify paths in operator CMakeLists.txt

comment:72 Changed 10 years ago by Owen Arnold

(In [9282]) refs #1624 fix error in paths

comment:73 Changed 10 years ago by Owen Arnold

(In [9302]) refs #1624 Template for delayed rebinning operator. Should accumulate reduction knowlege, but not actually rebin.

comment:74 Changed 10 years ago by Owen Arnold

(In [9317]) refs #1624 Fix const issue with RebinningCutterPresenter.

comment:75 Changed 10 years ago by Owen Arnold

(In [9321]) refs #1624 Fix leaking CutterOperator in chained schenario. Valgrind indicates that VisIT should be left to handle clean-up of input data sets in operators.

comment:76 Changed 10 years ago by Owen Arnold

(In [9328]) refs #1624 Show something sensible prior to operator execution to indicate why properties cannot be displayed.

comment:77 Changed 10 years ago by Owen Arnold

(In [9333]) refs #1624 Seperate out common/shared code.

comment:78 Changed 10 years ago by Owen Arnold

(In [9334]) refs #1624 Seperate out common/shared code.

comment:79 Changed 10 years ago by Owen Arnold

(In [9354]) refs #1624 Separtate out dimension creation from xml from bulky DynamicRebinFromXML algorithm. Also used in VATES rebinning code.

comment:80 Changed 10 years ago by Owen Arnold

(In [9436]) refs #1624 Progress update via ProgressAction Adapter pattern. Keeps Presenters unaware of VisIT, while allowing actual updates from algorithms to trigger progress updates in VisIT. Solves problem of inaction during long rebinning times.

comment:81 Changed 10 years ago by Owen Arnold

(In [9493]) refs #1624 Minor change/correction from last checkin to cpr.

comment:82 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:83 Changed 10 years ago by Owen Arnold

(In [9594]) re #1624. Minor fix to caching. Seed value needed to be fixed.

Remove time from GUI. The VisIT framework does not allow us to adapt time once it has been set in the reader/database.

comment:84 Changed 10 years ago by Owen Arnold

(In [9739]) re #1624. No need to re-load original MDWorkspace as should be available in the analysis data service. Also, enable tests for MDDataObjects.

comment:85 Changed 10 years ago by Owen Arnold

(In [9774]) re #1624. Fix issues identified by Michael while using the Rebinning cutter. Namely, the number of bins changing after changing the axis. Also a bug in the SetDimensions vtkDataSet call for vtkStructuredGridFactory, which prevented having non-uniform number of bins in each direction.

comment:86 Changed 10 years ago by Owen Arnold

(In [10577]) re #2774 #2607 #1624 Adapt VatesAPI to handle generic algorithm for reading data.

comment:87 Changed 10 years ago by Owen Arnold

(In [10648]) re #2774 #2607 #1624 Basic reader for Event nexus files added.

comment:88 Changed 10 years ago by Owen Arnold

(In [10651]) re #2774 #2607 #1624 includes not needed here.

comment:89 Changed 9 years ago by Owen Arnold

(In [11010]) re #2774 #2607 #1624 Modifications so that the workspace can be bound to an existing instance of a vtkDataSetFactory. Some enhancements for MDEventWorkspace visualisation.

comment:90 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:91 Changed 9 years ago by Owen Arnold

(In [11256]) re #1624. Recover dimension swapping capabilities after changes in underlying MDGeometry code.

comment:92 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:93 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Initial filter has been done for some time. Moving forward we should develop against more precise and specific tickets to improve the rebinning/cutting behaviour. This filter can be tested by (a) running it manually, (b) ensuring that the VatesAPI unit tests, which do most of the heavy-lifting run.

comment:94 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:95 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Unit tests run, and it works in the GUI (except if you rotate the box, I guess there isn't non-perpendicular binning)

comment:96 Changed 9 years ago by Owen Arnold

As an addition to this closing statement: Yes, we cannot apply non-axis aligned rebinning using MDGeometryDescriptions. EventNexusReader + BinToHistogramWorkspace is the only rebinning plugin + algorithmn using ImplicitFunctions at present.

comment:97 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2471

Note: See TracTickets for help on using tickets.