Ticket #1776 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Reducer: Refactor Instrument class

Reported by: Mathieu Doucet Owned by: Steve Williams
Priority: major Milestone: Iteration 26
Component: Mantid Keywords:
Cc: doucetm@… Blocked By:
Blocking: Tester: Martyn Gigg

Description

The Instrument class in SANSInsts.py still contains SANS2D-specific code. A basic version should be pulled out of SANSInsts and put into a common module.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Owner set to Mathieu Doucet
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Mathieu Doucet

  • Cc doucetm@… added
  • Owner changed from Mathieu Doucet to Steve Williams

The common Reducer is being refactor as part of ​ticket 1720. The SANS2D part should be refactored as part of SANS2D work.

comment:3 Changed 10 years ago by Steve Williams

(In [7449]) Reducer.py and instrument.py have moved into a central location (PythonAPI/scripts/reduction) re #1776

comment:4 Changed 10 years ago by Steve Williams

(In [7450]) Making a reducer.py error message clearer re #1776

comment:5 Changed 10 years ago by Mathieu Doucet

(In [7452]) Removed old reduction scripts. Re #1776

comment:6 Changed 10 years ago by Steve Williams

(In [7453]) Update the SANS GUI to use the scripts in the their new locations re #1776

comment:7 Changed 10 years ago by Mathieu Doucet

(In [7459]) update system test. Re #1776

comment:8 Changed 10 years ago by Mathieu Doucet

(In [7462]) Update Interface for new reduction location. Re #1776

comment:9 Changed 10 years ago by Steve Williams

  • Status changed from assigned to accepted

comment:10 Changed 10 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

Both ISIS SANS interfaces, the GUI (SANSRunWindow.cpp) and the Python (CommandInterface.py) load the new ISIS instruments' module isis_instrument

comment:11 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:12 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 26

Sorry I didn't mean to move these ones reverting back to It 26

comment:13 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:14 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

Confirmed that SANSInsts no longer exists and that the isis_instrument module is in use.

Reductions and centre finding seem to proceed correctly and give sensible results.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2623

Note: See TracTickets for help on using tickets.