Ticket #1815 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

CalculateTransmissionBeamSpreaderTest occasionally fails

Reported by: Russell Taylor Owned by: Janik Zikovsky
Priority: minor Milestone: Iteration 28
Component: Mantid Keywords:
Cc: doucetm@… Blocked By:
Blocking: Tester: Russell Taylor

Description

Could be a thread-safety problem.

Change History

comment:1 Changed 10 years ago by Russell Taylor

(In [7190]) This algorithm is clearly not thread safe (valgrind complains as well as the occasional test failures). Don't know what the problem is right now so I'm just going to disable parallelization for the time being. Re #1815.

comment:2 Changed 10 years ago by Mathieu Doucet

  • Cc doucetm@… added

comment:3 Changed 10 years ago by Russell Taylor

Hmm.... it's failed again a couple of times since the parallelization was removed.....

comment:4 Changed 10 years ago by Russell Taylor

  • Status changed from new to accepted

comment:5 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:6 Changed 10 years ago by Russell Taylor

(In [8297]) Re-enable parallelisation as that wasn't the problem anyway. Re #1815.

comment:7 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:8 Changed 10 years ago by Janik Zikovsky

  • Owner changed from Russell Taylor to Janik Zikovsky

comment:9 Changed 10 years ago by Janik Zikovsky

(In [10210]) Refs #1815: using PARALLEL_FOR instead of PARALLEL_SECTION (Russell's idea); this seems to fix CalculateTransmissionBeamSpreader segfaults.

comment:10 Changed 10 years ago by Janik Zikovsky

(In [10229]) Refs #1815: Made the Logger destructor thread-safe. This should fix any parallel Algorithm execution (two or more Algorithms started in parallel). Added test for Logger.

comment:11 Changed 10 years ago by Janik Zikovsky

(In [10230]) Refs #1815: Forgot the test file.

comment:12 Changed 10 years ago by Janik Zikovsky

(In [10233]) Refs #1815: Fix exception thrown by logger upon framework shutdown.

comment:13 Changed 10 years ago by Martyn Gigg

(In [10248]) Refs #1815. Avoided a static initialization problem on Windows MSVC where the mutex that Logger::get was using had not been created yet. Also fixed the incorrect eol-style property that I set before on the CMake files.

comment:14 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Seems to be working on all platforms. Will close.

comment:15 Changed 9 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:16 Changed 9 years ago by Russell Taylor

  • Status changed from verifying to closed

I didn't notice it failing in a long time.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2662

Note: See TracTickets for help on using tickets.