Ticket #1873 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Instrument geometry r and t parameters

Reported by: Vickie Lynch Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

Create new parameters "r" and "t" like "x", "y", and "z" that overwrite the r and t coordinate respectively of the <location> element of the component the <parameter> is a sub-element of. SNAP at SNS needs to read both r and t from logfiles.

Change History

comment:1 Changed 10 years ago by Anders Markvardsen

(In [7402]) Code to allow for the following notation added and tested, i.e. allow for parameters like "x", "y", "z" but where position coordinates are specified using spherical coordinates

<component type="dummy" name="rtpTest1">

<location x="12" y="12" z="12"/> <parameter name="r-position"> <value val="20.0" /> </parameter>

</component> <component type="dummy" name="rtpTest2">

<location x="12" y="12" z="12"/> <!-- this should have no effect --> <parameter name="t-position"> <value val="20.0" /> </parameter>

</component> <component type="dummy" name="rtpTest3">

<location x="12" y="12" z="12"/> <!-- this should have no effect --> <parameter name="p-position"> <value val="20.0" /> </parameter>

</component> <component type="dummy" name="rtpTest4">

<location x="12" y="12" z="12"/> <!-- this should have no effect --> <parameter name="p-position"> <value val="20.0" /> </parameter> <parameter name="t-position"> <value val="20.0" /> </parameter>

</component>

<component type="dummy" name="rtpTest5">

<location x="12" y="12" z="12"/> <parameter name="r-position"> <value val="20.0" /> </parameter> <parameter name="t-position"> <value val="90.0" /> </parameter>

</component>

<type name="dummy" />

Wiki http://www.mantidproject.org/InstrumentDefinitionFile updated accordingly.

re #1873

comment:2 Changed 10 years ago by Anders Markvardsen

(In [7403]) For some reason my machine is ok with shared pointers but not build server. Added version not using shared pointers.

re #1873

comment:3 Changed 10 years ago by Anders Markvardsen

(In [7405]) Too tired to try and figure out why Linux 64 don't like me code. Revert changes.

re #1873

comment:4 Changed 10 years ago by Vickie Lynch

(In [7421]) Refs #1873 Ander's changes work for linux now

comment:5 Changed 10 years ago by Vickie Lynch

(In [7425]) Refs #1873 Recommitting Ander's tests

comment:6 Changed 10 years ago by Anders Markvardsen

(In [7434]) Small cusmetic change. re #1873

comment:7 Changed 10 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Anders Markvardsen

comment:8 Changed 10 years ago by Anders Markvardsen

  • Status changed from assigned to accepted

comment:9 Changed 10 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

Vickie add usage of this feature in the SNAP IDF

comment:10 Changed 10 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:11 Changed 10 years ago by Vickie Lynch

  • Status changed from verifying to closed

Implemented this in SNAP IDF and just tested again that it still works.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2720

Note: See TracTickets for help on using tickets.