Ticket #1925 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Direct Inelastic: PSD bleed masking

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: major Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

If any pixel in a tube exceeds a user supplied max value then mask the entire tube.

This would need to be integrated into the Direct inestic convert to energy diagnositcs UI as an option step

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Summary changed from Direct Inelastic: PSD bleed macking to Direct Inelastic: PSD bleed masking

comment:2 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:3 Changed 10 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:4 Changed 10 years ago by Martyn Gigg

(In [8654]) Implemented an algorithm for calculating the required masking to kill bleed on long PSD tubes. Also factored another common function between the detector diagnostics. Need to test on MERLIN size data set for real performance test. Re #1925

comment:5 Changed 10 years ago by Martyn Gigg

(In [8661]) Temporarily disable multithreading that seems to be causing random test failures in release. Re #1925

comment:6 Changed 10 years ago by Martyn Gigg

(In [8712]) Corrected (i.e. matches libisis!) and sped up the PSD bleed diagnostic. MERLIN takes 0.6 seconds now rather than about 3. Re #1925

comment:7 Changed 10 years ago by Martyn Gigg

(In [8727]) Fix for CreatePSDBleedMaskTest. There was an off-by-one error in a debug statement that Janik spotted. Thanks!. Re #1925

comment:8 Changed 10 years ago by Martyn Gigg

(In [8813]) Incorporated the PSD bleed tests into the Inelastic GUI. Also cleanup up a few things around variables names in the script along with updating the parameter files to hold defaults for the bleed test. Re #1925

comment:9 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:10 Changed 10 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:11 Changed 10 years ago by Owen Arnold

  • Status changed from verifying to closed

(In [8813]) Incorporated the PSD bleed tests into the Inelastic GUI. Also cleanup up a few things around variables names in the script along with updating the parameter files to hold defaults for the bleed test. Re #1925

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2772

Note: See TracTickets for help on using tickets.