LoadDetectorInfo is getting stuck

[Martyn Gigg]

Changes in the way parameter maps are handled with parametrized components has affected the LoadDetectorInfo algorithm.

Parametrized components used to hold references to the ParameterMap and therefore creating one didn't affect the use count of the shared_ptr to the ParamMap in the workspace.

They now take a copy of the shared pointer and therefore update the use_count so that trying to access the instrumentParameters repeatedly causes a copy every time.

This needs to go back to references so that the only time it is copied is when a workspace copies and changes it.

[Martyn Gigg]

(In [7524]) Revert parametrized components to store a simple pointer to the parameter map to avoid excessive copying when the workspace copy mutates in an algorithm such as LoadDetectorInfo. Alog with this the excitations conversion script has been fixed so that it works with ISIS instruments. Also cleared a few warnings about no newlines. Re #1934

[Russell Taylor]

(In [7551]) Changes in [7542] turned out to be a bad idea for some reason (and I forgot to run the Algorithm tests to discover this sooner). Re #1934.

[Janik Zikovsky]

(In [8134]) Refs #1934.

[Stuart Campbell]

This ticket has been transferred to github issue ​2781