Ticket #1945 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

EventWorkspace: padPixels() in parallel?

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

Perhaps a function could be written inside the EventWorkspace class that would pad pixels in parallel, to make LoadSNSEventNexus faster...

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [7591]) Refs #1945: padPixels() function added to EventWorkspace to speed up pixel padding. This method is faster by a factor of ~2 versus the old way of padding, if parallel is kept off. For some reasone, the parallelized version is slower.

comment:3 Changed 10 years ago by Russell Taylor

(In [7602]) Windows fix. Re #1945.

comment:4 Changed 10 years ago by Russell Taylor

(In [7604]) Fix for windows, and actually test it on Windows before submitting this time. Changed to use Kernel::Timer class instead, which I think will do what you want. Re #1945.

comment:5 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Works well, even though it isn't in parallel.

comment:6 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:7 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 26

Sorry I didn't mean to move these ones reverting back to It 26

comment:8 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:9 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

performance of LoadSNSEventNexus is noticeably faster now compared to previous release.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2792

Note: See TracTickets for help on using tickets.