Ticket #1957 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

FilterByLogValue: when filtering in-place, avoid making a copy of the data.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

The current implementation requires creating a second workspace which overwrites the first one = double the memory usage, though temporarily.

This will require a filterInPlace() function or the like in EventList, to replace the splitByTime() functions which only works with different outputs.

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8114]) Fixes #1957: FilterByLogValue performed in place does not copy to a temporary, intermediate workspace. Also, filtering a TimeSeriesProperty with a single entry leaves it unchanged.

comment:3 Changed 10 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:4 Changed 10 years ago by Peter Peterson

  • Status changed from verifying to closed

This works as advertised.

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2804

Note: See TracTickets for help on using tickets.