Ticket #1997 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Allow multiple IDFs for single instrument

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

Allow notation in IDF:

1) <instrument name="CSP"

valid-from="yyyy-mm-ddThh:mm:ss" valid-to="yyyy-mm-ddThh:mm:ss">

2) Any number of say CSP_Definition#####.xml to be shipped with Mantid, where ##### is any string of any length

3) Add test to check that none of the valid-from to valid-to overlap for a given instrument

4) upon loading a raw file or any of the nexus files grap the date and load the appropriate IDF

Change History

comment:1 Changed 10 years ago by Anders Markvardsen

(In [7781]) Added valid-from and valid-to tags to all instrument as e.g.

<instrument name="ARCS" valid-from ="1900-01-31 23:59:59"

valid-to ="2100-01-31 23:59:59" last-modified="2010-10-12 08:54:07.279621">

Also added optional last-modified tag which takes the role of the previous optional date tag.

valid-from and valid-to will be compulsory tags and some code added to check this.

no wiki doc yet

removed unused WISH IDFs

re #1997

comment:2 Changed 10 years ago by Anders Markvardsen

(In [7785]) Fix broken test associated with previous commit to this ticket

re #1997

comment:3 Changed 10 years ago by Anders Markvardsen

(In [7820]) Some improved testing to test that valid-from and valid-to included in IDF. re #1997

comment:4 Changed 10 years ago by Anders Markvardsen

(In [7865]) Added test which will fail if any IDF is added with overlapping valid-from/valid-to dates. Note this test not is not in its final state but will fail in the event of the above. re #1997

comment:5 Changed 10 years ago by Anders Markvardsen

(In [7866]) Fix. re #1997

comment:6 Changed 10 years ago by Anders Markvardsen

(In [7867]) Fix. re #1997

comment:7 Changed 10 years ago by Anders Markvardsen

(In [7898]) More code towards having multiple IDFs for one instrument. re #1997

comment:8 Changed 10 years ago by Anders Markvardsen

(In [7948]) Extend LoadInstrument to include the input properties:

InstrumentName

This means there will be two input properties which can be used to specify and IDF:

Filename InstrumentName

If Filename is specified then use that this filename. If not then it is required that an InstrumentName is specified. And an appropriate filename is created at runtime (search the Workspace's Run object for "startdate"/"starttime" and get IDF search directory from Config)

Modify all loaders (except LoadEmptyInstrument) to load inst using this InstrumentName property re #1997

comment:9 Changed 10 years ago by Anders Markvardsen

(In [7949]) Fix broken test build. re #1997

comment:10 Changed 10 years ago by Anders Markvardsen

(In [7951]) Inconsistancy in how date stored in startdata. Temp fix for this. re #1997

comment:11 Changed 10 years ago by Anders Markvardsen

(In [7952]) It would be helpful if I committed the right files...... re #1997

comment:12 Changed 10 years ago by Anders Markvardsen

(In [7960]) Temp Fix for parsing dates. re #1997

comment:13 Changed 10 years ago by Anders Markvardsen

(In [7977]) Surprisingly painstaking to knock isis dates into iso 8601...

Introduced two now Workspace Run object properties:

run_end run_start

which stores date-time in iso 8601, for now this is done in LoadRawHelper and LoadISISNexus2.

wiki http://www.mantidproject.org/Run updated.

re #1997

comment:14 Changed 10 years ago by Russell Taylor

(In [7981]) Fix linux. Re #1997.

comment:15 Changed 10 years ago by Anders Markvardsen

(In [8004]) Updated wiki LoadInstrument and IDF and optional 'last-modified' tags in IDFs set to iso 8601. re #1997

comment:16 Changed 10 years ago by Anders Markvardsen

(In [8006]) Noticed one more place where Run prop "startdate/enddate" not been sub with run_start/run_end. re #1997

comment:17 Changed 10 years ago by Anders Markvardsen

  • Status changed from new to accepted

comment:18 Changed 10 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

Fixed, although to improved this further tickets created for next release #2046 and #2049

comment:19 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:20 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Good stuff, tried in with dummy TOPAZ instrument files. See #2074 for changes for SNS instruments.

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2844

Note: See TracTickets for help on using tickets.