Ticket #2019 (closed: fixed)
EQSANS: write algorithm to compute TOF offset
| Reported by: | Mathieu Doucet | Owned by: | Mathieu Doucet |
|---|---|---|---|
| Priority: | major | Milestone: | Iteration 26 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
The TOF values in the EQSANS data files have an uncorrected TOF starting at 0. We need an algorithm to compute the offset to be added to the TOF binning.
Change History
comment:3 Changed 10 years ago by Mathieu Doucet
- Status changed from accepted to verify
- Resolution set to fixed
comment:4 Changed 10 years ago by Mathieu Doucet
- Status changed from verify to reopened
- Resolution fixed deleted
comment:5 Changed 10 years ago by Mathieu Doucet
- Status changed from reopened to verify
- Resolution set to fixed
comment:6 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 26 to Iteration 27
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.
comment:7 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 26
Sorry I didn't mean to move these ones reverting back to It 26
comment:8 Changed 10 years ago by Michael Whitty
are there any EQSANS data files in the repository? can't seem to find any.
comment:9 Changed 10 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:10 Changed 10 years ago by Steve Williams
There are two files. Before being able to call the TOF offset.
LoadEventPreNeXus("/home/mantid/Downloads/eqsans/EQSANS_1466_neutron_event.dat", "eqevents")
LoadLogsFromSNSNexus("eqevents", "/home/mantid/Downloads/eqsans/EQSANS_1466.nxs")
comment:11 Changed 10 years ago by Peter Peterson
Matthieu says:
If you use run 1466, you should get a TOF offset of about 9500 I think. TOFOffset is an output parameter
comment:12 Changed 10 years ago by Peter Peterson
- Status changed from verifying to reopened
- Resolution fixed deleted
This works correctly...on run 1466 with frame skipping turned on the result is 9387.67 microseconds.
However, the InputWorkspace property on the algorithm should be set in the PyInit using
self.declareWorkspaceProperty("InputWorkspace", "", Direction.Input)
so there will be a drop-down of workspace names. Once that is done the ticket can be closed.
comment:13 Changed 10 years ago by Mathieu Doucet
comment:14 Changed 10 years ago by Mathieu Doucet
- Status changed from reopened to accepted
Fixed the same problem with another EQSANS algorithm while I was at it.
comment:15 Changed 10 years ago by Mathieu Doucet
- Status changed from accepted to verify
- Resolution set to fixed
comment:16 Changed 10 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester changed from Peter Peterson to Martyn Gigg
comment:17 Changed 10 years ago by Martyn Gigg
- Status changed from verifying to closed
Code change since last test on affect the property declaration and that has been succesful in providing the correct combo box on the dialog
comment:18 Changed 10 years ago by Mathieu Doucet
- Status changed from closed to reopened
- Resolution fixed deleted
Discovered a problem with the latest change. Algo won't run.
comment:19 Changed 10 years ago by Mathieu Doucet
comment:21 Changed 10 years ago by Mathieu Doucet
- Status changed from accepted to verify
- Resolution set to fixed
comment:22 Changed 10 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester changed from Martyn Gigg to Michael Reuter
comment:23 Changed 10 years ago by Michael Reuter
- Status changed from verifying to closed
It looks like the algorithm runs just fine now. I see the same result as Pete for the value of the EQSANS TOF offest. Also, this works fine without loading the logs from the histogram NeXus file. Mathieu says the value is correct.
comment:24 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2866
(In [7848]) First cut at TOF offset computation for EQSANS. Re #2019