Ticket #2028 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

SpatialGrouping algorithm

Reported by: Nick Draper Owned by: Michael Whitty
Priority: critical Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description (last modified by Nick Draper) (diff)

Spatial Grouping Parameters:

  • InputWS
  • FileName
  • nNeighbours - The number of nearest neighbours to average with (default 8)
  • SearchDistance - The maximum distance to search for neighbours in pixel widths (default 1.9)
  • KeepUngroupedSpectra

Operation

  • Searches for nearest neighbours to each pixel within searchDistance until it has the nearest nNeighbours or no more can be found
  • Creates an xml grouping file that can be used in GroupDetectors

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Description modified (diff)
  • Summary changed from SpatialAverage algorithm to SpatialGrouping algorithm

comment:2 Changed 10 years ago by Nick Draper

  • Description modified (diff)

comment:3 Changed 10 years ago by Michael Whitty

  • Status changed from new to accepted

comment:4 Changed 10 years ago by Michael Whitty

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8067]) fixes #2028 - SpatialGrouping algorithm, creates an XML grouping file for detectors based on the instruments geometry using NearestNeighbours functions.

comment:5 Changed 10 years ago by Michael Whitty

to be continued in #2061

comment:6 Changed 10 years ago by Michael Whitty

(In [8070]) fixes #2028 - missed some files on previous checkin [8067]

comment:7 Changed 10 years ago by Michael Whitty

(In [8072]) fixes #2028 - fix for linux/mac ?

comment:8 Changed 10 years ago by Michael Whitty

(In [8073]) fixes #2028 - fix for linux/mac ?

comment:9 Changed 10 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:10 Changed 10 years ago by Anders Markvardsen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Looks good, but as a cusmetic improvement when save file add *.xml as e.g. done in SaveAscii

comment:11 Changed 10 years ago by Michael Whitty

  • Status changed from reopened to accepted

comment:12 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:13 Changed 10 years ago by Michael Whitty

  • Milestone changed from Iteration 27 to Iteration 26

this one is for It 26.

comment:14 Changed 10 years ago by Michael Whitty

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8166]) fixes #2028 - adding extension filter to save file property on SpatialGrouping algorithm.

comment:15 Changed 10 years ago by Anders Markvardsen

  • Status changed from verify to verifying

comment:16 Changed 10 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Tested by saving IRIS grouping file and reload this file using GroupDetectors.

One small comment, consider printing an 'information' or 'warning' message to user when grouping file is generated which contain no <detids>, i.e. no grouping information.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2875

Note: See TracTickets for help on using tickets.