Ticket #2031 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Make FindCenterOfMassPosition return a position rather than pixels

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

The FindCenterOfMassPosition algo returns pixel coordinates. To do this, assumptions regarding the pixel order is made. The algo should return real-space coordinates and transformation to pixels should be done by the calling code if necessary.

Change History

comment:1 Changed 10 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Mathieu Doucet

(In [8538]) First cut at pixelization-independent center of mass calculation. Re #2031

comment:3 Changed 10 years ago by Mathieu Doucet

(In [8550]) Added tolerance. Re #2031

comment:4 Changed 10 years ago by Mathieu Doucet

(In [8615]) Next iteration of real-space beam finder. Now reproduce old HFIR code. All unit tests should now pass. Re #2031

comment:5 Changed 10 years ago by Mathieu Doucet

Wiki docs need updating. Also need to make sure the beam center translation is truly relative (use previous assumed position)

comment:6 Changed 10 years ago by Mathieu Doucet

(In [8641]) updated test data (tiny correction on two of the points) for analysis test. Re #2031

comment:7 Changed 10 years ago by Mathieu Doucet

(In [8678]) Committing working stopping point before proceeding with refactor. Re #2031

comment:8 Changed 10 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8681]) Fixes #2031

comment:9 Changed 10 years ago by Mathieu Doucet

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:10 Changed 10 years ago by Mathieu Doucet

  • Status changed from reopened to verify
  • Resolution set to fixed

(In [8700]) Correct units of parameter. Fixes #2031

comment:11 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:12 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified in 1.1.9520.

Using test data BioSANS_empty_cell.xml the FindCenterOfMassPosition2 algorithm returns seemingly sensible real-space coordinates.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2878

Note: See TracTickets for help on using tickets.