Ticket #2048 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Fix Diagnose Detectors to accept an event file.

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: blocker Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Nick Draper) (diff)

If you enter an event file (either nexus for prenexus) for the White Beam data in the diag tab then we get the error: 

FindDetectorsOutsideLimits: EventWorkspace::dataY cannot return a non-const array: you can't modify the histogrammed data in an EventWorkspace!

Change History

comment:1 Changed 10 years ago by Stuart Campbell

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8035]) fixes #2048

comment:3 Changed 10 years ago by Nick Draper

  • Description modified (diff)

comment:4 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:5 Changed 10 years ago by Janik Zikovsky

(In [8142]) Fixes #2069. Refs #2048, which now passes.

comment:6 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to closed

comment:7 Changed 10 years ago by Stuart Campbell

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:8 Changed 10 years ago by Stuart Campbell

This error has come back.

comment:9 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:10 Changed 10 years ago by Stuart Campbell

  • Milestone changed from Iteration 27 to Iteration 26

comment:11 Changed 10 years ago by Stuart Campbell

  • Status changed from reopened to accepted

comment:12 Changed 10 years ago by Stuart Campbell

This ticket is explicitly aimed at the ConvertToEnergy GUI. The separate algorithms should be made event aware at some point but as long as the inelastic scripts do the correct thing then that is ok for this release.

comment:13 Changed 10 years ago by Stuart Campbell

(In [8186]) Added some conversions to MatrixWorkspaces. refs #2048

comment:14 Changed 10 years ago by Stuart Campbell

(In [8207]) Added more conversions to MatrixWorkspaces. refs #2048

comment:15 Changed 10 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:16 Changed 10 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester changed from Janik Zikovsky to Andrei Savici

comment:17 Changed 10 years ago by Andrei Savici

  • Status changed from verifying to closed

It does not give an error

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2895

Note: See TracTickets for help on using tickets.