Ticket #2054 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

FFTSmooth: Add an option to use only Y values (allowing smoothing of log binned values)

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 26
Component: Mantid Keywords:
Cc: pf9@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description


Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [8030]) Refs #2054: Option to ignore the X Bins when performin a FFTSmooth.

comment:3 Changed 10 years ago by Janik Zikovsky

(In [8031]) Refs #2054: Help text.

comment:4 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:6 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 26

Sorry I didn't mean to move these ones reverting back to It 26

comment:7 Changed 10 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:8 Changed 10 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Tests using Test/Data/HRP39182.raw:

When 'ignoreXbin' unselected get error message:

Error in execution of algorithm RealFFT: X axis must be linear (all bins have same width) Error in direct FFT algorithm Error in execution of algorithm FFTSmooth: X axis must be linear (all bins have same width)

When 'ignoreXbin' selected smoothing works and a more smooth histogram is produced.

Comment: In error message you could add a line below "X axis must be linear (all bins have same width)" like

"User may select 'ignoreXbin' to true"

or something like this. Or alternatively have the algorithm default to 'ignoreXbin'=true if it fails to run with ignoreXbin=false

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2901

Note: See TracTickets for help on using tickets.