Ticket #2091 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

EventWorkspace: make a == operator (take code from CheckWorkspacesMatch)

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: minor Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description


Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [9132]) Fixes #2091: equals() function for quickly comparing workspaces. == operator cannot be overloaded since it compares the shared pointers rather than the actual contents.

comment:3 Changed 10 years ago by Michael Whitty

(In [9140]) refs #2091 - hopefully fix tests build for windows

comment:4 Changed 10 years ago by Brett Tully

  • Status changed from verify to verifying
  • Tester set to Brett Tully

comment:5 Changed 10 years ago by Brett Tully

  • Status changed from verifying to verify
  • Tester Brett Tully deleted

In response to my question as to why it is not working in Python, Janik says: "the equals method is defined only in the C++ code and was not exposed to Python, so that's why that's not working."

Thus, this ticket needs to be tested by someone with a development environment.

comment:6 Changed 10 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:7 Changed 10 years ago by Owen Arnold

  • Status changed from verifying to closed

Non-member equals function internally uses CheckWorkspacesMatch. verified via associated Algorithm unit tests.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2938

Note: See TracTickets for help on using tickets.