Ticket #2196 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Move test helpers into their own package

Reported by: Peter Peterson Owned by: Martyn Gigg
Priority: major Milestone: Iteration 27
Component: Infrastructure Keywords:
Cc: doucetm@… Blocked By:
Blocking: Tester: Janik Zikovsky

Description

As the tests are now compiled separately then linked together having Mantid/Geometry/test/ComponentCreationHelpers.hh, Mantid/Kernel/test/TestChannel.hh, and Mantid/Algorithms/test/WorkspaceCreationHelper.hh implemented in the headers makes an error upon linking.

Move these functions over into a separate package and split them into declaration (.h) and implementation (.cpp) files that the current tests can use.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Owner set to Russell Taylor
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Martyn Gigg

  • Status changed from assigned to accepted
  • Owner changed from Russell Taylor to Martyn Gigg

I had talked to Russell and Peter about this and am nearly there so I'll steal it.

comment:3 Changed 10 years ago by Martyn Gigg

(In [8526]) Added a TestHelpers package to hold code that is used for creating helper functions/classes for unit tests. Required for implementation of unit tests with CMake. Not quite active yet though. Re #2196.

comment:4 Changed 10 years ago by Martyn Gigg

(In [8527]) Reorganised using namespace declarations that were polluting the test helper headers. All are now in the cpp files. Ported over the SANSInstrumentCreationHelper and added it to the ComponentCreationHelper file. All the helper classes are ported but Scons knows nothing so the originals are left in their place. Re #2196

comment:5 Changed 10 years ago by Peter Peterson

(In [8529]) Putting some tests back in. Thanks Martyn. Refs #1881 and #2196.

comment:6 Changed 10 years ago by Peter Peterson

(In [8530]) Putting some tests back in. Thanks Martyn. Refs #1881 and #2196.

comment:7 Changed 10 years ago by Peter Peterson

(In [8535]) Putting in another test. Refs #1881 and #2196.

comment:8 Changed 10 years ago by Martyn Gigg

(In [8537]) Tell scons to build the new TestHelpers package so that ISIS buildservers are still happy with moving the test helpers while the CMake transition is still in progress. Refs #2196 and #1881

comment:9 Changed 10 years ago by Martyn Gigg

(In [8539]) Minor update to TestHelpers CMake script to get the correct link to DataHandling. Re #2196

comment:10 Changed 10 years ago by Martyn Gigg

(In [8540]) Update reference to helper classes include file. Re #2196

comment:11 Changed 10 years ago by Peter Peterson

(In [8544]) Putting back more tests. Refs #1881 and #2196.

comment:12 Changed 10 years ago by Peter Peterson

(In [8546]) Putting back more tests in CMake. Refs #1881 and #2196.

comment:13 Changed 10 years ago by Mathieu Doucet

  • Cc doucetm@… added

comment:14 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:15 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:16 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to closed

This has been working well for several weeks now, and I use the helpers frequently.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3043

Note: See TracTickets for help on using tickets.