Ticket #2214 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

SofQW appears incorrect for direct inelastic data

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: critical Milestone: Iteration 27
Component: Mantid Keywords:
Cc: campbellsi@… Blocked By:
Blocking: #2233 Tester: Steve Williams

Description

Spotted by Jon Taylor:

Look at the screenshots of MSlice and Mantid attched. Ignoring the transposed axes. The lower boundary in the data is different, in MSlice it curve upward with rising energy, but in Mantid is stays flat.

Attachments

Screen shot 2011-01-11 at 11.31.05.png​ (226.3 KB) - added by Nick Draper 10 years ago.

Change History

Changed 10 years ago by Nick Draper

comment:1 Changed 10 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner changed from Russell Taylor to Martyn Gigg
  • Priority changed from major to critical

comment:2 Changed 10 years ago by Stuart Campbell

  • Cc campbellsi@… added

comment:3 Changed 10 years ago by Martyn Gigg

  • Status changed from assigned to accepted

comment:4 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8782]) Fixed bug with SofQW that used the elastic relationship between mod(q) and theta. It now calculates q from the incident and final wave vectors directly. Fixes #2214

comment:5 Changed 10 years ago by Nick Draper

  • Blocking 2233 added

(In #2233) Bulk move of tickets at the end of iteration 27

comment:6 Changed 10 years ago by Steve Williams

  • Status changed from verify to verifying
  • Tester set to Steve Williams

comment:7 Changed 10 years ago by Steve Williams

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Couldn't repeat this because of a problem with Diagnose Detectors.

UnboundLocalError on line 4: "local variable '_bkgd_masks' reference before assignment" in file 'diagnostics.py' at line 128

comment:8 Changed 10 years ago by Martyn Gigg

(In [9519]) Fix for inelastic diag scripts that were crippled on windows by lack of background checks. Re #2214. Also added a "ManagedRawFileWorkspace.DoNotUse" (following existing syntax) property and set it to "1" so that ManagedRawFile workspaces are not used for the moment as they appear not to be working correctly. Re #2436

comment:9 Changed 10 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:10 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

To Test.

  • Open ConvertToEnergy
  • Select MARI
  • Run file=15537,white beam=15496, map file=mari_res.map(in Test/Data). Run files found with archive search on
  • Ei = 85, Rebin params = [-10, 0.1,80]
  • Hit run.
  • Load the SOfQW algorithm and point it to the output workspace generated from above.
  • Qbinning=[-0.3, 0.1,15]
  • Run

comment:11 Changed 10 years ago by Martyn Gigg

Minor alteration to test scheme.

The inputs for SofQW should be QBinning=[-5, 0.1,15] and EFixed=85.

A colour fill plot of the data then needs running where the colour bar scale has been reduce from 4e08 -> 50.

comment:12 Changed 10 years ago by Steve Williams

  • Status changed from verify to verifying

comment:13 Changed 10 years ago by Steve Williams

  • Status changed from verifying to closed

The Mantid plot looks similar to MSlice's now

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3061

Note: See TracTickets for help on using tickets.