Ticket #2220 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Eliminate spurious constructors in Kernel unit tests

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: critical Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Russell Taylor) (diff)

...starting with the ConfigServiceTest.

With CTest, even if a single test is run, all constructors are by default. The preference is not to have constructors, but where there is a good reason to have one, it is prevented from being called at start-up by adding the createSuite/destroySuite pair of static methods.

Change History

comment:1 Changed 10 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Russell Taylor

(In [8657]) Eliminate constructor from ConfigServiceTest. Re #2220.

comment:3 Changed 10 years ago by Russell Taylor

(In [8941]) Eliminate constructors in Kernel tests where possible. Prevent test suites that still have them from being turned into statics. Re #2220.

comment:4 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 10 years ago by Russell Taylor

(In [8942]) Try to make TimerTest more tolerant. Re #2220.

comment:6 Changed 10 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:7 Changed 10 years ago by Owen Arnold

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I may be mistaken, but given the title of the ticket, I can't say that the objectives have been met. The following tests in Kernel use constructors and have member variables:

BinaryFileTest, LogParserTest, PropertyTest, PropertyWithValueTest

comment:8 Changed 10 years ago by Russell Taylor

  • Status changed from reopened to accepted

comment:9 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Description modified (diff)
  • Summary changed from Eliminate constructors in Kernel unit tests to Eliminate spurious constructors in Kernel unit tests

Changed title and description to match what's been done!

comment:10 Changed 10 years ago by Owen Arnold

  • Status changed from verify to verifying

comment:11 Changed 10 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3067

Note: See TracTickets for help on using tickets.