Ticket #2221 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Eliminate data loading in constructors from Algorithm tests

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: critical Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description


Change History

comment:1 Changed 10 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Russell Taylor

(In [8670]) Eliminate data loading and prevent calling of constructor when running other suites. Re #2221

comment:3 Changed 10 years ago by Russell Taylor

  • Summary changed from Eliminate data loading and constructor from CalculateTransmissionTest to Eliminate data loading in constructors from Algorithm tests

comment:4 Changed 10 years ago by Russell Taylor

(In [8751]) Eliminate constructor from FindPeaksTest. Re #2221.

comment:5 Changed 10 years ago by Russell Taylor

(In [8753]) Eliminate constructor from ApplyTransmissionCorrectionTest. It still loads data and is very slow, which should be fixed sometime. Re #2221.

comment:6 Changed 10 years ago by Michael Whitty

(In [8877]) putting static construction methods into some tests (bunch in Algorithms, almost all in DataHandling) re #2221

comment:7 Changed 10 years ago by Russell Taylor

(In [8883]) Fix tests by removing ASSERTS that aren't testing the class in question anyway. Re #2221.

comment:8 Changed 10 years ago by Russell Taylor

(In [8885]) Fix GroupDetectors2Test for some cmake windows builds. The FrameworkManager needs to be stood up to load in other algorithms. Re #2221.

comment:9 Changed 10 years ago by Michael Whitty

(In [8929]) re #2221 - adding "boilerplate" code to more Tests in Algorithms

comment:10 Changed 10 years ago by Russell Taylor

(In [9068]) Eliminate data loading from a couple of test constructors. Also eliminate setUp method in several places. Re #2221.

comment:11 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

All Algorithms test have now had the data loading removed from their constructors, or the required code has been added to make the constructors only be called immediately before the suite is run.

There are also no remaining instances of the setUp method being used in this package.

Overall, there is plenty of data loading going on, which should be eliminated in due course.

comment:12 Changed 10 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:13 Changed 10 years ago by Owen Arnold

  • Status changed from verifying to closed

Data loading does not occur in default constructor unless constructor is called by static constructional method. All algorithms checked.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3068

Note: See TracTickets for help on using tickets.