Ticket #2269 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

LoadNexusProcessed: Handle EventWorkspaces

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description


Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [9342]) Refs #1525, #2268, #2269, #2355: SaveNexusProcessed and LoadNexusProcessed for event workspaces.

comment:3 Changed 10 years ago by Janik Zikovsky

(In [9343]) Refs #2269: Axis0 in EventWorkspace fix.

comment:4 Changed 10 years ago by Janik Zikovsky

(In [9344]) Refs #2269: Test fixes

comment:5 Changed 10 years ago by Janik Zikovsky

(In [9345]) Refs #2269: Muon tests in SaveNexusProcessed seem to cause segfaults; disabled for testing for now.

comment:6 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 10 years ago by Martyn Gigg

(In [9361]) Have to disable LoadNexusProcessed tests for Events at the moment as they are giving bad HEAP allocation errors ?? Re #2269

comment:8 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:9 Changed 10 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:10 Changed 10 years ago by Janik Zikovsky

(In [9364]) Refs #2269: Used a fixed 64 bit int type specifier since 'long' is platform-dependent.

comment:11 Changed 10 years ago by Janik Zikovsky

(In [9371]) Refs #2269: More making data types more platform independent.

comment:12 Changed 10 years ago by Janik Zikovsky

(In [9375]) Refs #2269: fix tests?

comment:13 Changed 10 years ago by Janik Zikovsky

(In [9376]) Refs #2269

comment:14 Changed 10 years ago by Janik Zikovsky

(In [9379]) Refs #2269

comment:15 Changed 10 years ago by Janik Zikovsky

(In [9380]) Refs #2269: More robust file handling in test.

comment:16 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

LoadNexus on EventWorkspaces works and is fairly fast - 12 seconds for a file that took 18 sec to load from a SNS Event Nexus, and took 88 seconds to save.

comment:17 Changed 10 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:18 Changed 10 years ago by Nick Draper

  • Status changed from verifying to verify
  • Tester Nick Draper deleted

I have been trying to load a small event file that I have saved first (using the data in Mantid/Test/Data/sns_event_prenexus/SEQ_TS_2009_01_06.dat)

This is a very small file, but on loading I get a bad allocation on windows, I have over 2GB available memory, and the original ws only took 9,350KB.

This needs to be Tested on Linux, if it passes there then we can spawn this off to another ticket for it28, otherwise it is a showstopper for it27.

comment:19 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:20 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

So this seems fine on Linux.

Spun out ticket for iteration 28, #2419

comment:21 Changed 10 years ago by Janik Zikovsky

I was also able to save and load the SEQ test data files...

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3116

Note: See TracTickets for help on using tickets.