Ticket #2277 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

BinaryOperation: perform with different number of spectra

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

  • This algorithm will apply a binary operation (Plus, Minus, Divide, Multiply) by matching the detector ID of the lhs to the detector IDs of the rhs.
  • For example, lhs is a normal WS, rhs is one where a nearest-neighbor average was performed. You want to divide lhs/rhs but match the right spectra together.
  • Should be able to handle cases where lhs AND rhs are averaged or summed. In this case, it will throw an error if any group on LHS is split over two+ groups on the rhs.

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [8915]) Refs #2277: Moved some useful functions from MergeRuns into a static function in BinaryOperation.

comment:3 Changed 10 years ago by Janik Zikovsky

(In [8916]) Refs #2277: Went back to previous MergeRuns version.

comment:4 Changed 10 years ago by Janik Zikovsky

(In [8917]) Refs #2277: buildBinaryOperationTable static method to match detector IDs between workspaces.

comment:5 Changed 10 years ago by Janik Zikovsky

(In [8946]) Refs #2277: Divide algorithm has new parameter to perform division by grouped spectra, where workspace indices do not match. e.g. sample / vanadium (where vanadium was averaged per bank). Refs #2023.

comment:6 Changed 10 years ago by Janik Zikovsky

  • Summary changed from BinaryOperationByDetectorID: New algorithm to BinaryOperation: perform with different number of spectra

comment:7 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [9020]) Fixes #2277: A million tests for every possible permutation of multiply and divide workspace. Whew!

comment:8 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:9 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

tested in [9515]. tested dividing one workspace by a grouped workspace, sensible results.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3124

Note: See TracTickets for help on using tickets.