Ticket #2333 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Change return type of Algorithm::createSubAlgorithm from to an Algorithm_sptr

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

because it should never be used outside of an Algorithm (or derived class) anyway.

Currently it's an IAlgorithm_sptr, which means that the new executeAsSubAlg method has to be in IAlgorithm interface instead of protected within Algorithm.

Change History

comment:1 Changed 10 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Russell Taylor

(In [9062]) Change return type of Algorithm::createSubAlgorithm from IAlgorithm to Algorithm. Re #2333.

comment:3 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 10 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 10 years ago by Owen Arnold

  • Status changed from verifying to closed

Verified change made to code base. Now returns boost::shared_ptr<Algorithm>.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3180

Note: See TracTickets for help on using tickets.