Ticket #2376 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

EQSANS: Fix problem with background subtraction

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Steve Williams

Description

The UI is generating a Mantid python script that contains commands for HFIR SANS that are not allowed for EQSANS. Also need to fix when the sample-det-distance is updated when a file is loaded.

Change History

comment:1 Changed 10 years ago by Mathieu Doucet

(In [9330]) Fix background issue. Re #2376

comment:2 Changed 10 years ago by Mathieu Doucet

(In [9332]) Move SDD to workspace properties instead of keeping it in a python object where it can be overwritten. Re #2376

comment:3 Changed 10 years ago by Mathieu Doucet

(In [9340]) Minor change to allow a LoadRun class to only load files that have not already in a clean workspace . Re #2376

comment:4 Changed 10 years ago by Mathieu Doucet

(In [9341]) Fix SDD code in the UI. Re #2376

comment:5 Changed 10 years ago by Mathieu Doucet

  • Status changed from new to accepted

How to test: check that sample-detector-distance is kept as a workspace property. Check that the sns_command_interface imports specific functions from hfir_command_interface.

comment:6 Changed 10 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:8 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to verify
  • Tester Janik Zikovsky deleted

I was not able to test this ticket (not sure where to start...)

comment:9 Changed 10 years ago by Steve Williams

  • Status changed from verify to verifying
  • Tester set to Steve Williams

comment:10 Changed 10 years ago by Steve Williams

  • Status changed from verifying to closed

Mantid takes a shock and dies if "Calculate transmission" is selected, I guess because this is still under development.

The sampledetectordetector distance is writen to the workspace's run object and I didn't find an apparent Python error.

Minor thing in the logs in red WARNING! LoadSNSEventNexus is .... call LoadEventNexus ...

comment:11 Changed 10 years ago by Mathieu Doucet

I opened a ticket to fix the crash. #2495

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3223

Note: See TracTickets for help on using tickets.