Use executeAsSubAlg() in more places to run child algoritms.

[Janik Zikovsky]

Refs #2319. There are about 20 spots where it could use it:

Mantid
Framework
Algorithms
src
CalculateEfficiency.cpp
66: childAlg->execute(); 
CalculateTransmission.cpp (2 matches)
189: childAlg->execute(); 
224: childAlg->execute(); 
ConvertUnits.cpp
656: childAlg->execute(); 
DetectorDiagnostic.cpp (2 matches)
72: childAlg->execute(); 
204: childAlg->execute(); 
DiffractionFocussing.cpp (3 matches)
98: childAlg->execute(); 
177: childAlg->execute(); 
214: childAlg->execute(); 
FindDeadDetectors.cpp
148: childAlg->execute(); 
FlatBackground.cpp
313: childAlg->execute(); 
GetEi.cpp
261: childAlg->execute(); 
GetEi2.cpp (2 matches)
239: childAlg->execute(); 
499: childAlg->execute(); 
HRPDSlabCanAbsorption.cpp
176: childAlg->execute(); 
MedianDetectorTest.cpp
175: childAlg->execute(); 
NormaliseToMonitor.cpp
225: childAlg->execute(); 
RemoveBins.cpp
211: childAlg->execute(); 
SumRowColumn.cpp
112: childAlg->execute(); 
Unwrap.cpp
400: childAlg->execute(); 

[Janik Zikovsky]

(In [11372]) Fixes #2426: Removed lots of duplicated code for running sub algorithms.

[Peter Peterson]

I'm sure that things were perfectly clean when you originally closed the ticket, but a couple cropped up that you should deal with.

$ ack-grep "childAlg->execute\(\)" Code/Mantid/Framework/ 
Code/Mantid/Framework/Algorithms/src/DetectorDiagnostic.cpp
193:      childAlg->execute();

Code/Mantid/Framework/Algorithms/src/MedianDetectorTest.cpp
184:        childAlg->execute();

Code/Mantid/Framework/Algorithms/src/FindDeadDetectors.cpp
157:        childAlg->execute();

[Janik Zikovsky]

In each of these cases the algorithms needed some custom error handling that would not work with executeAsSubAlg(), so these will be skipped.

[Martyn Gigg]

Confirmed widespread usage of executeAsSubAlg.

[Michael Reuter]

Looks like this should have been closed.

[Stuart Campbell]

This ticket has been transferred to github issue ​3273