MantidPlot: scripting window can crash Mantid if a python script is running

[Mathieu Doucet]

• Start a python algorithm that will run for a long time (from the algorithm list)
  
• Click the python script icon to make the scripting window appear.
  
• Kill the scripting window using the X button
  
• Click the python script icon to make the scripting window reappear.
  
• If the python algorithm is still running, MantidPlot will seg fault.

This seems to be related to the fact that a new PythonScript object is created whenever a scripting window or tab is created.

Comment out the following lines in PythonScript.cpp and there will be no crash. On the other hand you will lose all the Mantid imports (which could be done at execution time anyway):

  PyObject *pymodule = PyImport_AddModule("__main__");
  localDict = PyDict_Copy(PyModule_GetDict(pymodule));

[Martyn Gigg]

(In [10192]) Refs #2562 #2556. Should fix problems with scripting window interaction when other things are runnning. The GIL needs aquiring so that Pythn can switch between different running sections, i.e. a Python algorithm from the GUI and a script. Annoying small local changes seems to have had quite an impact.

[Roman Tolchenov]

It is still crashing

[Martyn Gigg]

This seems to have been fixed as it doesn't occur for me now.

[Martyn Gigg]

Most up-to-date dev build and release build from servers seems okay.

[Owen Arnold]

Only works if the scripting window has been opened prior to running the python algorithm. Tried with the python squares algorithm

Algorithm: Squares v1 Parameters:

Name: MaxRange, Value: 1000000, Default?: No, Direction: Input Name: Preamble, Value: 100000, Default?: No, Direction: Input Name: Sum, Value: 1, Default?: No, Direction: Input Name: OutputFile, Value: C:\MantidInstall\bin\1, Default?: No, Direction: Input Name: OutputWorkspace, Value: 1, Default?: No, Direction: Output

[Martyn Gigg]

(In [11186]) Two parts: Fix issue with python scripting window crashing while a python algorithm is running (not an ideal fix but a new issue has been created to sure up the stuff properly. Fixes #2556. Fix for crash when viewing curve properties from the right-click menu on the plot. Fixes #2890

[Owen Arnold]

Checked exact situation that was brining down Mantid previously. Works with latest (development) build.

[Stuart Campbell]

This ticket has been transferred to github issue ​3403