Ticket #2574 (closed: fixed)
Indirect Diffraction Reduction interface - changes...
| Reported by: | Michael Whitty | Owned by: | Nick Draper |
|---|---|---|---|
| Priority: | major | Milestone: | Iteration 29 |
| Component: | MantidPlot | Keywords: | |
| Cc: | Blocked By: | #2916 | |
| Blocking: | Tester: | Martyn Gigg |
Description
Need:
- NormaliseByCurrent option
- actual feature to divide by vanadium file (rather than just a box)
- anything else Franz thinks of
Change History
comment:3 Changed 9 years ago by Michael Whitty
I think there need to be two interfaces, perhaps based on selection of the instrument.
For Interface A, which is closest to what we currently have, we will support IRIS and TOSCA. Neither of these are really diffraction instruments, so they don't go for the whole vanadium workflow. Basically it's just a divide by monitor thing.
For Interface B, we will support OSIRIS. This is a "real" diffraction instrument, so has a different workflow.
We could, in theory, just tie it to the instrument name - but that they're doing such different things makes me think we should have a different look/feel for each. Possibly a tab to select...
(just putting this here as a note in case I don't get around to doing it myself)
comment:8 Changed 9 years ago by Michael Whitty
- Status changed from accepted to verify
- Resolution set to fixed
This has been done, sortof. The options in the description are included in the OSIRISDiffractionReduction python algorithm (separate). That algorithm should give as much interface as OSIRIS needs. This interface is focussed on TOSCA & IRIS for now, with option for later expansion.
comment:9 Changed 9 years ago by Nick Draper
- Owner changed from Michael Whitty to Martyn Gigg
Moved from Michael Whitty, ask Martyn if you have any questions during testing
comment:10 Changed 9 years ago by Nick Draper
- Owner changed from Martyn Gigg to Nick Draper
Moved so they can be tested
comment:11 Changed 9 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:12 Changed 9 years ago by Martyn Gigg
- Status changed from verifying to closed
Verfied that the interface works for IRIS and TOSCA. The documentation says it does not work for OSIRIS and indeed it does not.
I'm not sold on the look of the box window it looks half-finished but that may well be the case if Michael ran out of time. It appears to be doing sensible things for a diffraction instrument.
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 3421
Bulk move of tickets at the end of iteration 28