Ticket #2604 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Fix beam centre problems

Reported by: Steve Williams Owned by: Steve Williams
Priority: critical Milestone: Iteration 28
Component: MantidPlot Keywords:
Cc: richard.heenan@… Blocked By:
Blocking: Tester: Michael Reuter

Description

From Richard Heenan 

...

Actually the beam centre finder need to leave the rows & columns masks from the mask file in place whilst it is running. (On LOQ we mask out the top two rows H126>H127 of the detector, which are shadowed or not working properly. ...

Mantid people – could we use a 1mm starting step for LOQ, but still 5mm for SANS2d please.

Change History

comment:1 Changed 10 years ago by Steve Williams

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Steve Williams

(In [9864]) BatchReduce() now accepts an argument specifying the save algorithm to use. Stop beam centre finder from reloading the mask file when it shouldn't re #2604 and #2603

comment:3 Changed 10 years ago by Steve Williams

(In [9927]) Batch reduce now saves in all the file formats listed on the bottom right of the form re #2604

comment:4 Changed 10 years ago by Steve Williams

(In [9933]) Fix the build re #2604

comment:5 follow-up: ↓ 6 Changed 10 years ago by Steve Williams

(In [10091]) ISIS SANS Batch reduce saves the correct extensions for each algorithm it saves with and save files no longer confirms overwrite when appending re #2604 and #2217

comment:6 in reply to: ↑ 5 Changed 10 years ago by Steve Williams

this commit should have been to #2603

comment:7 Changed 10 years ago by Steve Williams

Also could the scrolling output text box which monitors the centre finding process be wider and/or have better formatted text columns writing to it, to make the process easier to monitor.

comment:8 Changed 10 years ago by Steve Williams

(In [10247]) In the ISIS SANS beam finder the initial step sizes are given in LOQ_Parameters.xml and SANS2D_Parameters.xml re #2604

comment:9 Changed 10 years ago by Steve Williams

(In [10287]) Account for the reduced step size in the beam centre finder for LOQ re #2604

comment:10 Changed 10 years ago by Steve Williams

(In [10288]) Account for the reduced step size in the beam centre finder for LOQ in the systems test re #2604

comment:11 Changed 10 years ago by Steve Williams

(In [10389]) The SANS beam centre finder wasn't reading in the step size as a float re #2604

comment:12 Changed 10 years ago by Steve Williams

There also needs to be a edit box in the GUI

comment:13 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:14 Changed 9 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [11118]) Fix a problem with the new SANS GUI and the centre finder fixes #2604

comment:15 Changed 9 years ago by Russell Taylor

  • Milestone changed from Iteration 29 to Iteration 28

comment:16 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:17 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

The spurious dropping points at low Q are no longer present, so the fix worked.

comment:18 Changed 9 years ago by Michael Reuter

The above statement is not for this ticket. However, I do see that the step sizes have been added and properly read in, so this is fine.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3451

Note: See TracTickets for help on using tickets.