Ticket #2624 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Consistent rebin behaviour

Reported by: Nick Draper Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

From Garrett:

If the Input and Output workspaces are the same during a rebin process, the workspace type remains event where if they are different, it converts to a 2D workspace.

By default it should always convert. Alternatively there should be a flag to tell it to convert or not.

From Russell:

I agree with this request - when I was sitting at the back of the Mantid demo and this behaviour was explained it struck me that it was slightly evil and I meant to bring it up.

Probably a PreserveEvents property is appropriate (though it is unfortunate that this would then show up in the algorithm gui even when it's irrelevant).

Any objections? I realise there will be scripts to fix.....

Change History

comment:1 Changed 10 years ago by Russell Taylor

  • Owner changed from Russell Taylor to Janik Zikovsky
  • Status changed from new to assigned

Add a PreserveEvents or KeepEvents property and make it true by default (in contrast to what Garrett suggested).

At the same time, rename the MatrixWorkspaceOut property on DiffractionFocussing to match this.

comment:2 Changed 10 years ago by Janik Zikovsky

  • Status changed from assigned to accepted

comment:3 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [10536]) Fixes #2624: Rebin now has a parameter to PreserveEvents, instead of relying on the name to decide what type of workspace the output should be. Also, change in DiffractionFocussing parameters: check your scripts!

comment:4 Changed 10 years ago by Russell Taylor

(In [10552]) Fix SNS reducer for less-magic Rebin algorithm. Re #2624.

comment:5 Changed 9 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:6 Changed 9 years ago by Michael Whitty

  • Status changed from verifying to closed

tested in 11105. I have updated the documentation for Rebin to reflect this change.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3471

Note: See TracTickets for help on using tickets.