Ticket #2663 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Eliminate the file for MantidsimpleAPI

Reported by: Nick Draper Owned by: Mathieu Doucet
Priority: critical Milestone: Iteration 29
Component: Python Keywords:
Cc: Blocked By:
Blocking: #2404, #3076 Tester: Nick Draper

Description

If this can be done in memory only then it should

Change History

comment:1 Changed 10 years ago by Mathieu Doucet

  • Blocking 2404 added

comment:2 Changed 10 years ago by Peter Peterson

(In [10466]) Adding ability to create algorithm proxy directly from a string and version number. Refs #2663.

comment:3 Changed 10 years ago by Peter Peterson

(In [10515]) Exposing function to get the order of properties in python. Refs #2663.

comment:4 Changed 10 years ago by Peter Peterson

(In [10516]) Added setProperties to IAlgorithmProxy to consolodate the code, with support code from FrameworkManagerProxy. Also upgraded PythonAlgorithm.executeSubAlg to use improvements done elsewhere as well. Refs #2663.

comment:5 Changed 10 years ago by Peter Peterson

(In [10517]) Override the default behaviour for IAlgorithmProxy.execute so it takes into account whether or not everything is in gui mode. Refs #2663.

comment:6 Changed 10 years ago by Peter Peterson

(In [10523]) Using new functionality in IAlgorithmProxy. Refs #2663.

comment:7 Changed 10 years ago by Mathieu Doucet

(In [10533]) Changes needed for executeSubAlg. Re #2663

comment:8 Changed 10 years ago by Mathieu Doucet

(In [10535]) Changes needed for executeSubAlg. Re #2663

comment:9 Changed 10 years ago by Mathieu Doucet

(In [10537]) Modified Reducer to use new alg creation method, and added back the ReducerTest. Re #2663

comment:10 Changed 10 years ago by Mathieu Doucet

(In [10539]) Fix qti import problem... Re #2663

comment:11 Changed 10 years ago by Peter Peterson

(In [10541]) Moving the import into a better place. Refs #2663.

comment:12 Changed 10 years ago by Peter Peterson

(In [10542]) For regular function defs, is calling IAlgorithmProxy.execute(). Refs #2663.

comment:13 Changed 10 years ago by Mathieu Doucet

(In [10543]) Expose version number parameter for createSubAlgo. Re #2663

comment:14 Changed 10 years ago by Mathieu Doucet

(In [10545]) Use version number param for createSubAlg in MantidFramework. Re #2663

comment:15 Changed 10 years ago by Mathieu Doucet

(In [10546]) forgot something... Re #2663

comment:16 Changed 10 years ago by Peter Peterson

(In [10571]) Changed the execute call in the Dialog version of functions. Refs #2663.

comment:17 Changed 10 years ago by Peter Peterson

(In [10585]) Moved all of the mantidHelp stuff into MantidFramework. Refs #2663.

comment:18 Changed 10 years ago by Peter Peterson

(In [10586]) Removing dead code. Refs #2663.

comment:19 Changed 10 years ago by Peter Peterson

(In [10587]) Removing check for a def that isn't supposed to be there. Refs #2663.

comment:20 Changed 10 years ago by Peter Peterson

(In [10588]) Removing more dead code. Refs #2663.

comment:21 Changed 10 years ago by Peter Peterson

(In [10589]) Removing silly execute kwarg. Refs #2663.

comment:22 Changed 10 years ago by Mathieu Doucet

(In [10590]) Moving a sys.path mod to its proper place. Re #2663

comment:23 Changed 10 years ago by Peter Peterson

(In [10678]) Removed a bit more code from mantidsimple in favor of using features in MantidFramework. Refs #2663.

comment:24 Changed 10 years ago by Peter Peterson

(In [10702]) Changed return policy to not be the thing that boost actively discourages. Refs #2663.

comment:25 Changed 10 years ago by Peter Peterson

(In [10703]) Squashing bug on rewrapping IAlgorithmProxy inside an IAlgorithmProxy. Refs #2663.

comment:26 Changed 10 years ago by Peter Peterson

(In [10705]) Consolidated much of the setProperty code. Refs #2663.

comment:27 Changed 9 years ago by Peter Peterson

(In [10734]) Moved exception handling into MantidFramework. Refs #2663.

comment:28 Changed 9 years ago by Peter Peterson

(In [10766]) Moved _convertToPair into mtd. Refs #2663.

comment:29 Changed 9 years ago by Peter Peterson

(In [10807]) Changing property names to be valid variable names. Refs #2663.

comment:30 Changed 9 years ago by Peter Peterson

(In [10808]) Changing property names to be valid variable names. Refs #2663.

comment:31 Changed 9 years ago by Peter Peterson

(In [10809]) Changing property names to be valid variable names. Refs #2663.

comment:32 Changed 9 years ago by Peter Peterson

(In [10810]) Changing property names to be valid variable names. Refs #2663.

comment:33 Changed 9 years ago by Peter Peterson

(In [10811]) Changing property names to be valid variable names. Refs #2663.

comment:34 Changed 9 years ago by Peter Peterson

(In [10812]) Changing property names to be valid variable names. Refs #2663.

comment:35 Changed 9 years ago by Peter Peterson

(In [10813]) Changing property names to be valid variable names. Refs #2663.

comment:36 Changed 9 years ago by Peter Peterson

(In [10814]) Changing property names to be valid variable names. Refs #2663.

comment:37 Changed 9 years ago by Peter Peterson

(In [10817]) Moved most of the dialog versions into MantidFramework.py and got rid of the silly sanitizing of variable names. Refs #2663.

comment:38 Changed 9 years ago by Peter Peterson

(In [10821]) Disabling bad test for now since running tests in parallel creates a race condition. Refs #2663.

comment:39 Changed 9 years ago by Peter Peterson

(In [10822]) Error out if people try to use a dialog when not in gui mode. Refs #2663.

comment:40 Changed 9 years ago by Peter Peterson

(In [10835]) Changing property names to be valid variable names. Refs #2663.

comment:41 Changed 9 years ago by Russell Taylor

(In [10864]) Fix ICat gui for changes to property names. Re #2663.

comment:42 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:43 Changed 9 years ago by Russell Taylor

  • Priority changed from minor to critical
  • Blocking 3076 added

The existence of the file can cause problems when using MPI - when multiple processes can be running on the same machine with the same owner (and all try to write the file more or less simultaneously).

comment:44 Changed 9 years ago by Martyn Gigg

  • Status changed from new to assigned
  • Owner changed from Martyn Gigg to Peter Peterson

comment:45 Changed 9 years ago by Mathieu Doucet

(In [12241]) Create a runtime version of mantidsimple. Re #2663

comment:46 Changed 9 years ago by Mathieu Doucet

(In [12246]) Addition to CMakeLists. Re #2663

comment:47 Changed 9 years ago by Mathieu Doucet

(In [12262]) Poof. Goodbye mantidsimple.py Re #2663

comment:48 Changed 9 years ago by Mathieu Doucet

  • Owner changed from Peter Peterson to Mathieu Doucet

comment:49 Changed 9 years ago by Mathieu Doucet

(In [12266]) Added Dialog version of algorithms. Re #2663

comment:50 Changed 9 years ago by Mathieu Doucet

(In [12281]) Added back python reduction test Re #2663

comment:51 Changed 9 years ago by Mathieu Doucet

(In [12287]) Added Load and LoadDialog Re #2663

comment:52 Changed 9 years ago by Russell Taylor

(In [12288]) Attempt to add mantidsimple_runtime to Windows install. Re #2663.

comment:53 Changed 9 years ago by Mathieu Doucet

(In [12309]) Final cleanup of mantidsimple. mantidsimple.py is no longer generated at runtime but sits with MantidFramework.py Re #2663

comment:54 Changed 9 years ago by Mathieu Doucet

(In [12310]) add mantidsimple.py to Windows install. Re #2663.

comment:55 Changed 9 years ago by Mathieu Doucet

  • Status changed from assigned to accepted

comment:56 Changed 9 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:57 Changed 9 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:58 Changed 9 years ago by Nick Draper

  • Status changed from verifying to closed

The file itself is not completely removed, but it's contents is vastly reduced, the existing functionality appears to have been maintained once this fixes to the intellisense are considered.

comment:59 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3510

Note: See TracTickets for help on using tickets.