Ticket #2673 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

GetEi does not work for LET

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description (last modified by Martyn Gigg) (diff)

The GetEi algorithm fails for LET because the spectrum used for the monitor is a DetectorGroup. Jon Taylor says that while this is spectrum is not a monitor in the strict sense of the word, hence not marked in the IDF, it can be used without a problem for determining Ei.

Also Jon has supplied an updated IDF and parameter file for LET to be committed.

Change History

comment:1 Changed 10 years ago by Martyn Gigg

  • Status changed from new to accepted

Test case:

  • Load some LET data;
  • Run GetEi with parameters: mon1 = 24582, mon2=5506, ei guess = 1.5

comment:2 Changed 10 years ago by Martyn Gigg

(In [10124]) Refs #2673. Updated GetEi2 so that it now doesn't throw an error if the one of the spectra used to determine Ei is a group: required for use with LET at ISIS. Updated the LET IDF and added a parameter file. Minor workspace name fix.

comment:3 Changed 10 years ago by Martyn Gigg

(In [10130]) Refs #2673. Fix for direct ConvertToEnergy diagnosis.

comment:4 Changed 10 years ago by Martyn Gigg

(In [10135]) Refs #2673. Correct the mon-1 spectrum in the LET parameter file so that ConvertToEnergy doesn't produce NANs.

comment:5 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 9 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:7 Changed 9 years ago by Michael Whitty

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Tried with the following runs:

LET1001, LET1435, LET1448

And got these error messages:

from 1001:

Error retrieving monitor spectra from input workspace. Check input properties.
Error in execution of algorithm GetEi:
Error retrieving monitor spectra spectra from input workspace.

from 1435 and 1448:

Error in execution of algorithm GetEi:
No peak found in data that satisfies prominence criterion

comment:8 Changed 9 years ago by Martyn Gigg

  • Status changed from reopened to accepted
  • Description modified (diff)

comment:9 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

So my test case should have been a litte more specific. The Ei parameter is only correct for a given run, cycle_10_01/LET00001083 hence the "No peak found in data that satisfies prominence criterion" error above.

As for the first error, LET is new and it looks as if the several files have their monitors defined in different places. The later data files have the monitors in the correct place and Jon Taylor is satisfied with it working on LET at the moment.

A working example is run 1083, Ei=1.5 with spectra 24582 and 5506.

comment:10 Changed 9 years ago by Michael Whitty

  • Status changed from verify to verifying

comment:11 Changed 9 years ago by Michael Whitty

  • Status changed from verifying to closed

aapologies for my misunderstanding. tested in 11153 with given parameters & it gives a result.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3520

Note: See TracTickets for help on using tickets.