Modify save nxspe option and nxspe file format to keep L2 and correct angular values

[Alex Buts]

Current nxspe file format contains the information about angular positions of the detectors. This information is calculated from instrument's description by save nxspe algorithm. Unfortunately, the algorithm works incorrectly if any map except 1:1 is used, so the information in nxspe file is incorrect. In addition to that, distance from sample to detectors is needed for number of algorithms, using spe and nxspe data

Needed: 1) Save sample-to-detectors distances in nxspe file. 2) savenxspe algorithm needs requesting par of phx file (the files with proper angular detectors positions defined), if any map except 1:1 is specified. This will allow to modify this algorithm, adding sub-algorithms to identify proper angular positions and sizes of combined (mapped) detectors for different combinations of instruments and maps in a future. When all these sub-algorithms are available, a phx or par files would be obsolete.

[Stuart Campbell]

Adding L2 covered in ticket #2826

[Nick Draper]

Bulk move of tickets at the end of iteration 28

[Alex Buts]

(In [11706]) refs #2745 par identification algorithm separated from SaveNXSPE algorithm.

[Alex Buts]

(In [11708]) refs #2745 linux compilation error fixed

[Alex Buts]

(In [11915]) refs #2745 detectorsRing class inheriting from detectors group has been added (not fully functional yet)

[Alex Buts]

(In [11916]) refs #2745 link error fixed

[Alex Buts]

(In [11921]) refs #2745 DetectorsRing are more viable class now (not completed) testRings added

[Alex Buts]

(In [11922]) refs #2745 compilation error with ring fixed

[Alex Buts]

(In [11923]) refs #2745 warning and tabs modified

[Alex Buts]

(In [11924]) refs #2745 warning and tabs modified

[Alex Buts]

(In [11994]) refs #2745 detectors ring class removed and DetectorGroup modified to have method, which tries to establish its topology

[Alex Buts]

(In [11995]) refs #2745 attempt to fix linux comp error

[Alex Buts]

(In [11996]) refs #2745 attempt to fix linux comp error

[Alex Buts]

(In [12072]) refs #2745 generally completed but more tests are needed

[Alex Buts]

(In [12073]) refs #2745 algorithm part committed (generally completed but more tests are needed)

[Alex Buts]

(In [12076]) refs #2745 two more tests for getting non-axis aligned BB

[Alex Buts]

(In [12101]) refs #2745 test for calculating the detectors ring par-s

[Alex Buts]

(In [12102]) refs #2745 tests which failing because mutableSpectraMap is not avail temporary disabled

[Alex Buts]

(In [12103]) refs #2745 tests returned back

[Alex Buts]

(In [12104]) refs #2745 syntax?

[Alex Buts]

(In [12109]) refs #2745 improved version of identify_topology sub-algorithm

[Alex Buts]

(In [12110]) refs #2745 temporary disabling failing test pending investigations

[Alex Buts]

(In [12111]) refs #2745 test enabled, check if passes

[Alex Buts]

(In [12112]) refs #2745 warning fixed

[Alex Buts]

(In [12125]) refs #2745 Changed values between azimuthal and polar for rings. minor changes to code.

[Alex Buts]

(In [12126]) refs #2745 committed part, missed previously

[Alex Buts]

(In [12140]) refs #2745 additional properties and tests

[Alex Buts]

(In [12144]) refs #2745 warnings

[Alex Buts]

(In [12203]) refs #2745 Tests and partial code to load par or phx files if necessary

[Alex Buts]

(In [12204]) refs #2745 fixing tests failing on UNIX

[Alex Buts]

(In [12205]) refs #2745 fixing tests failing on UNIX

[Alex Buts]

(In [12206]) refs #2745 fixing tests failing on UNIX

[Russell Taylor]

(In [12224]) Fix FindDetectorsParTest on Mac. From Mac OS X, line endings are the same as any other UNIX. Re #2745.

[Alex Buts]

(In [12228]) refs #2745 fixing tests failing on UNIX and more tests for par file loaded

[Alex Buts]

(In [12229]) refs #2745 committed to clarify the error under Unix

[Alex Buts]

(In [12230]) refs #2745 disabling suspicious tests one by one

[Alex Buts]

(In [12231]) refs #2745 disabling suspicious tests one by one

[Alex Buts]

(In [12232]) refs #2745 trying to identify Unix problem

[Alex Buts]

(In [12233]) refs #2745 trying to identify Unix problem

[Alex Buts]

(In [12234]) refs #2745 enabling everything that should be fine

[Alex Buts]

(In [12235]) refs #2745 and now committing suspicious peace

[Alex Buts]

(In [12236]) refs #2745 modified a bit attempting to overcome GCC oddity

[Alex Buts]

(In [12238]) refs #2745 warnings on Ubuntu

[Alex Buts]

(In [12239]) refs #2745 test file to check against existing MARI par file

[Alex Buts]

(In [12254]) refs #2745 final tests and conclusion; it should be it if everything works fine on real systems

[Alex Buts]

(In [12263]) refs #2745 test file renamed and minor modifications to the algorithm

[Alex Buts]

(In [12321]) refs #2745 final tests and conclusion; it should be it if everything works fine on real systems algorithm to calculate azimuthal width in cylindrical system has changed, which may be wrong for square detectors (and there should have 365% anyway) but may be reasonable for maps. refs #3127 SaveNXSPE modified to write NaN instead of -1e+30; Questionable but can be easy reverted

[Alex Buts]

works satisfactory despite some annoyances, which can be fixed in within other tickets.

[Alex Buts]

works satisfactory despite some annoyances, which can be fixed in within other tickets.

[Alex Buts]

(In [12347]) refs #2745 the discrepancy between ISIS and SNS par files in nxspe has been fixed. refs #3127 erroneous nxspe test file with correct NaNs but wrong angular values deleted.

[Alex Buts]

(In [12352]) refs #2745 fixing failing test for det angular width

[Alex Buts]

(In [12440]) refs #2745 changed the location of bounding box wrt to the beam line and detector to calculate angular detector's sizes more accurately in Cartesian topology case;

[Alex Buts]

(In [12441]) refs #2745 attempting to fix recent errors on Linux

[Alex Buts]

(In [12442]) refs #2745 fixing recent errors on Linux

[Alex Buts]

(In [12489]) refs #2745 savePHX uses the same algorithm as saveNXSPE and the format modified to correspond the one from ISIS Bounding box is always tangential to 2theta=const line

[Alex Buts]

(In [12491]) refs #2745 fixing failing Bounding box test (Non-axis aligned BB behaviour have changed)

[Alex Buts]

(In [12494]) refs #2745 fixing failing finddetectors and save NXSPE test; (algorithm behaviour changed)

[Alex Buts]

(In [12495]) refs #2745 fixing failing finddetectors and save NXSPE test; (algorithm behaviour changed)

[Alex Buts]

(In [12498]) refs #2745 fixing win tests

[Alex Buts]

(In [12741]) refs #2745 saveNXSPE has NaNs as default for Ei and Phi if nothing is provided as a property, so user can easy see that nothing meaningful has been set when the algorithm was deployed

[Andrei Savici]

It does not overwrite L2. Is it supposed to be this way?

[Stuart Campbell]

This ticket has been transferred to github issue ​3592