Ticket #2830 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

MDEWPeakIntegration: Peak integration in reciprocal space for MDEventWorkspace

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: critical Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

It would be nice to pass a functor to the MDGridBox instead of hiding the functionality in the classes. So try to do that first, and then use that to make a simple Peak Integrator (aka all within R of x,y,z). Can make it general to N dimensions, why not!

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

(In [10871]) Refs #2830: Stub for reciprocal space peak integration.

comment:3 Changed 9 years ago by Janik Zikovsky

(In [10877]) Refs #2830: Stub for a task object to be used for generic methods to apply on MDBoxes.

comment:4 Changed 9 years ago by Janik Zikovsky

(In [10897]) Refs #2830: Checkpointing some MDBoxTask-related code; might remove later.

comment:5 Changed 9 years ago by Janik Zikovsky

(In [10930]) Refs #2830: Removed MDBoxTask that might be causing Win build failures?

comment:6 Changed 9 years ago by Janik Zikovsky

(In [10931]) Refs #2830: Removed MDBoxTask that might be causing Win build failures?

comment:7 Changed 9 years ago by Janik Zikovsky

(In [11073]) Refs #2831, #2830: Coordinate transformation that measures the distance (squared) between an event and a point.

comment:8 Changed 9 years ago by Janik Zikovsky

  • Milestone changed from Iteration 28 to Iteration 29

comment:9 Changed 9 years ago by Janik Zikovsky

(In [11209]) Refs #2830: Steps towards peak integration; works for simple MDBoxes.

comment:10 Changed 9 years ago by Janik Zikovsky

(In [11236]) Refs #2830: MDGridBox preliminary peak integration. Also, windows build fix?

comment:11 Changed 9 years ago by Janik Zikovsky

(In [11241]) Refs #2830: Peak integration for MDGridBoxes by looking for contained vertices in order to only dig into the required boxes.

comment:12 Changed 9 years ago by Janik Zikovsky

(In [11242]) Refs #2830: Added sphere integration performance tests, cleaned up some std output.

comment:13 Changed 9 years ago by Janik Zikovsky

(In [11245]) More work on algorithm for peak integration refs #2830.

comment:14 Changed 9 years ago by Janik Zikovsky

(In [11274]) Refs #2830: Added constructor with HKL for Peak object. Improved random fake MDEventData generation for use in test. Fixed subtle bug in MDGridBox spherical integration. Finalized and added test for MDEWPeakIntegration. Added method on IMDBox to getExtentsStr()

comment:15 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [12118]) Fixes #2830: MDEW peak integration with background subtraction.

comment:16 Changed 9 years ago by Janik Zikovsky

  • Summary changed from MDEventWorkspace: peak integration to MDEWPeakIntegration: Peak integration in reciprocal space for MDEventWorkspace

comment:17 Changed 9 years ago by Janik Zikovsky

(In [12148]) Refs #839, Refs #2830: Performance test for reciprocal space integration. About 10000 peaks per second on my system.

comment:18 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:19 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

Very fast integration. Accepts input from real data with peaks. Wiki should be updated with additional input options and results compared with known integrated peaks.

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3677

Note: See TracTickets for help on using tickets.