Ticket #2846 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Tidy up SANS Reducer

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

  • Try not to load the instrument definition at init time.
  • Removed as much of the instrument parameters from the instrument class as possible. Keep them as instrument parameters or run parameters.
  • Fix unicode problems in the UI on Windows.

Change History

comment:1 Changed 9 years ago by Mathieu Doucet

  • Status changed from new to accepted

Also need to:

  • Avoid reloading the sample data after the reduction is done. get_data_info() seems to be called.
  • Make sure that the checked parameters in the Experiments Parameters on the REduction Options tab are NOT updated when a sample data file is selected. Only update the parameters that are not checked.

comment:2 Changed 9 years ago by Mathieu Doucet

(In [11007]) fixed various update problems. Re #2846

comment:3 Changed 9 years ago by Mathieu Doucet

(In [11097]) Tidy up reduction code RE #2846

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:5 Changed 9 years ago by Mathieu Doucet

(In [11110]) Tidy up reduction code RE #2846

comment:6 Changed 9 years ago by Mathieu Doucet

(In [11173]) Tidy up reduction code RE #2846

comment:7 Changed 9 years ago by Mathieu Doucet

(In [11220]) Minor tweak to fix rare path issue on Windows. Re #2846

comment:8 Changed 9 years ago by Mathieu Doucet

(In [11238]) Nicer fix for file path bug on Windows. Re #2846

comment:9 Changed 9 years ago by Mathieu Doucet

(In [11239]) Final tweak. Re #2846

comment:10 Changed 9 years ago by Mathieu Doucet

(In [11273]) Major revamp of EQSANS UI Re #2846

comment:11 Changed 9 years ago by Mathieu Doucet

(In [11343]) Fix EQSANS system test Re #2846

comment:12 Changed 9 years ago by Mathieu Doucet

(In [11348]) Fix EQSANS system test Re #2846

comment:13 Changed 9 years ago by Mathieu Doucet

(In [12545]) Eliminated instrument loading when instantiating HFIR & EQSANS Reducer. Re #2846

comment:14 Changed 9 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

Done. We got rid of the instrument loading in the init of EQSANS and HFIRSANS.

comment:15 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:16 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to closed

Difficult to test this ticket, but it doesn't crash and Mathieu is happy.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3693

Note: See TracTickets for help on using tickets.