Ticket #2859 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

PeakIntegration: Add a test

Reported by: Janik Zikovsky Owned by: Vickie Lynch
Priority: minor Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

I made some changes to your PeakIntegration script that should be checked (to account for the new PeaksWorkspace structure), but there is no test for it.

Change History

comment:1 Changed 9 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Vickie Lynch

Commit message that is missing:

(In [11689]) Refs #2859 Test for PeakIntegration

comment:3 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to reopened
  • Resolution fixed deleted

Test failing on mac and windows

comment:5 Changed 9 years ago by Vickie Lynch

(In [11722]) Refs #2859 Removing unneeded include statement

comment:6 Changed 9 years ago by Vickie Lynch

(In [11748]) Refs #2859 Removing PeakIntegration test until it runs on Mac and Windows

comment:7 Changed 9 years ago by Vickie Lynch

(In [11819]) Refs #2859 Test for PeakIntegration

comment:8 Changed 9 years ago by Vickie Lynch

(In [11821]) Refs #2859 Test for PeakIntegration still does not work on Mac so removing again

comment:9 Changed 9 years ago by Vickie Lynch

(In [11863]) Refs #2859 PeakIntegrationTest, but not in CMakeLists.txt

comment:10 Changed 9 years ago by Vickie Lynch

  • Status changed from reopened to accepted

comment:11 Changed 9 years ago by Vickie Lynch

(In [12169]) Refs #2859 Reduced time for PeakIntegration test

comment:12 Changed 9 years ago by Vickie Lynch

(In [12173]) Refs #2859 Fix test for windows

comment:13 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

Test seems to run on all platforms in less than two second now

comment:14 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:15 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

Yes, it looks like this runs on all systems.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3706

Note: See TracTickets for help on using tickets.