Ticket #2870 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Peak: improvements for inelastic scattering, etc.

Reported by: Janik Zikovsky Owned by: Andrei Savici
Priority: minor Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

Minor defects and enhancements needed

  • 1. Add a constructor that allows to set hkl and goniometer rotation matrix.Also initialize the rotation matrix to unity if not set otherwise
  • 2. In getWavelength check E_initial=E_final
  • 3. In getTOF, you should not assume elastic scattering. tof=d_samp_source/v_initial+d_sample_detector/v_final
  • 4. Point 3 is especially important for getting qlab
  • 5. In QSampleFrame you need to multiply with the inverse (or the transpose if you want to. they are the same for a rotation matrix)

Change History

comment:1 Changed 9 years ago by Andrei Savici

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Andrei Savici

(In [12040]) small changes for Peak object. refs #2870

comment:3 Changed 9 years ago by Andrei Savici

(In [12061]) small changes for Peak object. refs #2870

comment:4 Changed 9 years ago by Andrei Savici

(In [12064]) Some doxygen warnings in Peak. refs #2870

comment:5 Changed 9 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [12091]) Fixed tests. Made sure you cannot use singular matrix for goniometer. There is no check if it's a real rotation matrix. Fixes #2870

comment:6 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

#1: Yes. #2: Returns final energy, that's okay. #3: Yes. #4: Also accounts for ei/ef #5: Done.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3717

Note: See TracTickets for help on using tickets.