Ticket #2871 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

LoadPeaksFile: make goniometer matrix, and handle it in Peak object.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: minor Milestone: Iteration 29
Component: Mantid Keywords:
Cc: vel@… Blocked By:
Blocking: Tester: Vickie Lynch

Description

Get dSpacing does not agree with .peaks file because the goniometer rotation is not taken into account.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Milestone changed from Iteration 28 to Iteration 29

Change description:

Possible problem reading in row/column from ISAW peaks file.

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Janik Zikovsky

(In [11143]) Refs #2871: Fix to TOPAZ geometry (detectors had wrong rotation) fixes the d-spacing reading problem in LoadPeaksFile.

comment:4 Changed 9 years ago by Janik Zikovsky

(In [11145]) Refs #2871: Missing test file

comment:5 Changed 9 years ago by Janik Zikovsky

(In [11146]) Refs #2871: Fix for older TOPAZ geometry in the same way, confirmed with test in LoadPeaksFile.

comment:6 Changed 9 years ago by Janik Zikovsky

(In [11147]) Refs #2871: Fix for older TOPAZ geometry in the same way, confirmed with test in LoadPeaksFile.

comment:7 Changed 9 years ago by Janik Zikovsky

(In [11148]) Refs #2871: Fix to TOPAZ geometry.

comment:8 Changed 9 years ago by Janik Zikovsky

(In [11149]) Refs #2871: Update TOPAZ geometry

comment:9 Changed 9 years ago by Janik Zikovsky

(In [11150]) Refs #2871: Fix test.

comment:10 Changed 9 years ago by Janik Zikovsky

(In [11151]) Refs #2871: Fix test build

comment:11 Changed 9 years ago by Janik Zikovsky

(In [11152]) Refs #2871: Disabling test because merging individual files is a pain.

comment:12 Changed 9 years ago by Janik Zikovsky

(In [11172]) Refs #2871: Goniometer matrix in Loading Peaks files.

comment:13 Changed 9 years ago by Janik Zikovsky

(In [11188]) Refs #2871: Use the goniometer rotation matrix in Peak getQSampleFrame. Refs #2841: Algorithm to predict peaks: added a visualization output, parallelized.

comment:14 Changed 9 years ago by Janik Zikovsky

(In [11193]) Refs #2871: Goniometer matrix Peaks test file.

comment:15 Changed 9 years ago by Janik Zikovsky

(In [11199]) Refs #2871: More output in test to see where the discrepency is.

comment:16 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:17 Changed 9 years ago by Janik Zikovsky

(In [11210]) Refs #2871: Round fix for windows?

comment:18 Changed 9 years ago by Janik Zikovsky

(In [11230]) Refs #2871: Possible fix for rint() on windows?

comment:19 Changed 9 years ago by Janik Zikovsky

(In [11232]) Refs #2871: Yet another try at rounding for Windows.

comment:20 Changed 9 years ago by Janik Zikovsky

(In [11233]) Refs #2871: Yet another try at rounding

comment:21 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:22 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

Peaks found match those found from ISAW on Topaz data

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3718

Note: See TracTickets for help on using tickets.