Ticket #2928 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

MantidPlot can crash if geometry algebra string is set wrongly in IDF

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

While definiting user may accidently specific a wrong algebra string. For example:

<type name="pixel" is="detector">

<cuboid id="top">

<left-front-bottom-point x="0.0025" y="-0.035" z="0.0" /> <left-front-top-point x="0.0025" y="0.035" z="0.0" /> <left-back-bottom-point x="0.0025" y="-0.035" z="0.001" /> <right-front-bottom-point x="-0.0025" y="-0.035" z="0.0" />

</cuboid>

<algebra val="toop" />

</type>

where <algebra val="toop" /> should have read <algebra val="top" />.

Example above crashing MantidPlot. Put in code to avoid crash and give user some warning information.

Change History

comment:1 Changed 9 years ago by Anders Markvardsen

(In [11967]) Fix to: MantidPlot can crash if geometry algebra string is set wrongly in IDF re #2928

comment:2 Changed 9 years ago by Anders Markvardsen

  • Status changed from new to accepted

To test change one of the algebra string in any of the IDF to something nonsense, which should no longer crash MantidPlot if resulting IDF is loaded.

comment:3 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 9 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:5 Changed 9 years ago by Nick Draper

  • Status changed from verifying to closed

tested using load empty instrument, and hand editing an instrument file.

Warning message and no crash spotted.

v1.29.12843

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3775

Note: See TracTickets for help on using tickets.