Ticket #2943 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Rebinning in nDimensions

Reported by: Owen Arnold Owned by: Alex Buts
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

We currently have working CenterPiece rebinning code for 4Dimensional (qx, qy, qz, en), which in under test in MDAlgorithms. This indirectly includes use of Load_MDWorkspace which reads 4D sqw files.

We need separate test cases to ensure that the multidimensional CetrePiece rebinning algorithms are truly nDimensional. This should cover 2D, 3D cases etc.

Change History

comment:1 Changed 9 years ago by Alex Buts

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Alex Buts

(In [11493]) refs #2943; incomplete modifications to test file format class. Committed to disable failing test for XML rebinning (started to fail after repo changes?)

comment:3 Changed 9 years ago by Owen Arnold

(In [11547]) refs #2943 Test should work.

comment:4 Changed 9 years ago by Alex Buts

(In [11559]) refs #2943; minor changes to kill remaining size_t warning on linux

comment:5 Changed 9 years ago by Alex Buts

(In [11561]) refs #2943; warnings -- a bit more changes to kill them.

comment:6 Changed 9 years ago by Alex Buts

(In [11562]) refs #2943; warnings -- a bit more changes to kill them.

comment:7 Changed 9 years ago by Alex Buts

(In [11563]) refs #2943; warnings -- a bit more changes to kill them (Odd copy constructor).

comment:8 Changed 9 years ago by Owen Arnold

(In [11572]) refs #2943 DynamicRebinFromXML Algorithm fixed. Tests should now work.

comment:9 Changed 9 years ago by Alex Buts

(In [11587]) refs #2943; some tests enabled; Redundant tests deleted and excluded from CMakeLists.txt

comment:10 Changed 9 years ago by Alex Buts

(In [11600]) refs #2943; warnings; should be two less

comment:11 Changed 9 years ago by Alex Buts

(In [12354]) refs #2943 MDGeometry description can be copied from a pointer to it;

comment:12 Changed 9 years ago by Alex Buts

(In [12356]) refs #2943 warning fixed

comment:13 Changed 9 years ago by Alex Buts

(In [12622]) refs #2943 Separate test dataset emulating an sqw file for any-Dim rebinning has been created and tested

comment:14 Changed 9 years ago by Alex Buts

(In [12623]) refs #2943 fixing linux compilation error

comment:15 Changed 9 years ago by Alex Buts

(In [12624]) refs #2943 fixing projects files rearrangement error

comment:16 Changed 9 years ago by Alex Buts

(In [12625]) refs #2943 fixing projects namespaces rearrangement error

comment:17 Changed 9 years ago by Alex Buts

(In [12627]) refs #2943 reducing the size of test datasets to make test execution time acceptable

comment:18 Changed 9 years ago by Alex Buts

(In [12628]) refs #2943 fixing some tests which started to fail because of previous modifications

comment:19 Changed 9 years ago by Alex Buts

(In [12629]) refs #2943 temporary disabling a test with unclear reason for failure

comment:20 Changed 9 years ago by Alex Buts

(In [12630]) refs #2943 load_ws_test back to normal

comment:21 Changed 9 years ago by Alex Buts

(In [12631]) refs #2943 fixing testDatasetTest

comment:22 Changed 9 years ago by Alex Buts

(In [12632]) refs #2943 test preselect_cells correctly working with new dataset

comment:23 Changed 9 years ago by Alex Buts

(In [12635]) refs #2943 test CPR-rebinning works correctly with new dataset

comment:24 Changed 9 years ago by Alex Buts

(In [12636]) refs #2943 bunch of warning

comment:25 Changed 9 years ago by Alex Buts

(In [12640]) refs #2943 bunch of warning

comment:26 Changed 9 years ago by Alex Buts

(In [12642]) refs #2943 tricky range error fixed

comment:27 Changed 9 years ago by Alex Buts

(In [12643]) refs #2943 bunch of warnings

comment:28 Changed 9 years ago by Alex Buts

(In [12646]) refs #2943 test CPR-rebinning keeps pixels works correctly with new dataset; memory manager needs amending

comment:29 Changed 9 years ago by Alex Buts

(In [12689]) refs #2943 bunch of warnings

comment:30 Changed 9 years ago by Alex Buts

(In [12690]) refs #2943 fixing errors due to linux oddity

comment:31 Changed 9 years ago by Alex Buts

(In [12693]) refs #2943 one more warning

comment:32 Changed 9 years ago by Alex Buts

(In [12726]) refs #2943 one more warning fixed

comment:33 Changed 9 years ago by Alex Buts

(In [12798]) refs #2943 rebinning tested and works on 2D test dataset

comment:34 Changed 9 years ago by Alex Buts

(In [12799]) refs #2943 fixing linux compilation error

comment:35 Changed 9 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

test cases created for any dimensions but current rebinning intended to be used on 3-reciprocal+ any orthogonal dimensions only. A rebinning incorrect for any cut with n-Reciprocal dimensions<3 and the limits for cut in orthogonal dimensions not passing through 0.

This is expected behaviour as current rebinning function intended to work and is heavily optimized for 3 reciprocal dimensions.

rebinning factory and other rebinning classes should be provided for different numbers of reciprocal dimensions

comment:36 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:37 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

comment:38 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3790

Note: See TracTickets for help on using tickets.