Ticket #2987 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

DiffractionEventCalibrateDetectors: use GroupingWorkspaces

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

... this should speed up calibration.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [11363]) Fixes #2987: DiffractionEventCalibrateDetectors uses GroupingWorkspaces, which should speed it up by maybe 2x.

comment:3 Changed 9 years ago by Janik Zikovsky

(In [11364]) Fixes #2987: forgot a file, sorry.

comment:4 Changed 9 years ago by Martyn Gigg

(In [11789]) Refs #2987. Fix issues with some code I wrote a while a go that shows up as a a warning on the Mac. Also cleaned up another prevalent warning from IMDGeometry.

comment:5 Changed 9 years ago by Martyn Gigg

(In [12026]) Refs #2987. Add an additional warning flag on MSVC, one about comparison of unsigned types and zero, so that it matches the gcc setup a bit more closely.

comment:6 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:7 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

DiffractionFocusing on PG3_2538 took 2.65 sec with GroupingWorkspace and 2.75 with Cal file. With SNAP_4307 13.80 sec with GroupingWorkspace and 17.81 with Cal file.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3834

Note: See TracTickets for help on using tickets.