Ticket #2993 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Allow users to delete rows from table workspaces

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Iteration 29
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Nick Draper) (diff)

This should be implemented using a DetelTableRow algorithm, but should be also attached to the Delete Row right click option on the table that is displayed in mantidplot.

This also needs ticket #2944

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Description modified (diff)

comment:2 Changed 9 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Roman Tolchenov

(In [11985]) Added algorithm for deleting rows from a TableWorkspace. re #2993

comment:4 Changed 9 years ago by Roman Tolchenov

(In [11986]) fixing PythonAPI. re #2993

comment:5 Changed 9 years ago by Roman Tolchenov

(In [11987]) An error in a include file name. re #2993

comment:6 Changed 9 years ago by Roman Tolchenov

(In [11988]) Removed some warnings concerning unsigned integers. re #2993

comment:7 Changed 9 years ago by Mathieu Doucet

(In [12023]) Fixing warnings... Re #2993

comment:8 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:10 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Valid input works here, but passing a negative value causes a crash.

It is also not too clear what input is required for "Rows" parameter, does the input start at zero or 1? The MantidPlot display starts indexing at 1 but the algorithm at 0 so this could be confusing to users as the property comment does not specify either.

There is also no documentation for the algorithm: http://www.mantidproject.org/DeleteTableRows

comment:11 Changed 9 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:12 Changed 9 years ago by Roman Tolchenov

(In [12851]) Added range checking to the DeleteTableRows algorithm. Row numbers in MantidTable start with 0 now. re #2993

comment:13 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 9 years ago by Roman Tolchenov

(In [12856]) It seems array property on some platforms cannot process negative numbers. re #2993

comment:15 Changed 9 years ago by Roman Tolchenov

(In [12857]) Fixing the test. re #2993

comment:16 Changed 9 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester changed from Martyn Gigg to Andrei Savici

comment:17 Changed 9 years ago by Andrei Savici

Right click - delete row works

comment:18 Changed 9 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3840

Note: See TracTickets for help on using tickets.