Ticket #2995 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Allow dimension configuration for Event Nexus Reader

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Iteration 29
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

Dimension properties are currently hard-coded for this reader. We already have widgets that can do this sort of configuration, but in order to use them geometry xml must be obtained from imddimension types. Currently generation of the xml is the responsibility of the MDGeometry type, which is not used for event-based visualisation.

1) Extract the geometry xml logic from MDGeometry 2) Enable dimensional configuration for vtkEventNexusReader

Change History

comment:1 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Owen Arnold

(In [11356]) re #2995 Refactoring. Pull out xml creation from geometry so that it can be used elsewhere.

comment:3 Changed 9 years ago by Owen Arnold

(In [11544]) re #2995. Dimension configuration now similar to that for non-event based rebinning cutting. Note: sorry for size of commit, have not been able to get work into SVN owing to server build problems.

comment:4 Changed 9 years ago by Owen Arnold

(In [11786]) re #2995. Enforce rule that mapped dimensions cannot be integrated. In order to be integrated, they must be recorded as Ordinary dimensions only (not aligned to x, y, z, t). This cannot be done at the IMDWorkspace + IDMDimension levels, so delegated to Parsing. Rule is switchable at compile time. Next step is to have Qt widgets respect this rule too.

comment:5 Changed 9 years ago by Owen Arnold

(In [11788]) re #2995. Fixes test macro usage.

comment:6 Changed 9 years ago by Owen Arnold

(In [11793]) re #2995. Prevent nbins == 1 on mapped dimensions via dimension widget.

comment:7 Changed 9 years ago by Owen Arnold

(In [11795]) re #2995. Because Event-based rebinning can use ImplicitFunctions and MD-CPR cannot. With MD-CPR axis aligned cuts are very important and must be syncronised with Box selector. We therefore prevent this happening by disabling dimensions limit selection for MD-CPR type filters.

comment:8 Changed 9 years ago by Owen Arnold

(In [11841]) re #2995. Switch dimension between integrated/non-integrated in the GUI. This is incompletely hooked-up. Actually a good deal of logic is needed to keep perfect synchronisation between non-integrated/integrated dimensions behind the scenes. This will come next.

comment:9 Changed 9 years ago by Owen Arnold

(In [12075]) re #2995. Move to MVP design. Avoid smart-widget type QT widgets. Synchronisation logic introduced for moving between integrated and non-integrated dimensions.

comment:10 Changed 9 years ago by Owen Arnold

(In [12093]) re #2995. Multidimensional rebinning should now make ubiqutious use of vtkDataSetFactories via getSignalNormalizedAt

comment:11 Changed 9 years ago by Owen Arnold

(In [12094]) re #2995. Minor fix. Scope resolution error in header.

comment:12 Changed 9 years ago by Owen Arnold

(In [12159]) re #2995. fix TODO. Improve test coverage.

comment:13 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:15 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

I've used this.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3842

Note: See TracTickets for help on using tickets.